Draft
Conversation
10f82ba to
1757524
Compare
Author
Author
|
I am seeing some automated CI failures which I will try to address ASAP. Let me know if you have any other feedback that you would like me to address other than the CI failures. |
Collaborator
|
@Samahu Hey, thank you for the PR! Since the SDK is quite big, I'd actually prefer it being a submodule (or if it's locatable by colcon, an entry in Having it in the source tree directly makes it harder to update/keep in sync with the upstream as there's no direct Git relationship between them anymore. If you can provide a rosbag with packets or a PCAP, I'll test the PR once the above changes are done. Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


PR Type
Related Links
Closes #212
Description
The PR adds support for all current generation Ouster Lidars running FW 2.2 through 3.2
Review Procedure
sensor_model.param.yamland set thesensor_ipanddest_ipto match your environmentRemarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks