Skip to content

test: cover nebula_velodyne_common calibration#429

Open
mojomex wants to merge 8 commits intotier4:mainfrom
mojomex:test/velodyne-common-unit-coverage
Open

test: cover nebula_velodyne_common calibration#429
mojomex wants to merge 8 commits intotier4:mainfrom
mojomex:test/velodyne-common-unit-coverage

Conversation

@mojomex
Copy link
Copy Markdown
Collaborator

@mojomex mojomex commented Mar 31, 2026

Summary

  • add focused unit tests for nebula_velodyne_common
  • cover return-mode parsing, status streaming, sensor configuration streaming, and calibration YAML read-write paths
  • fix the package public link interface so nebula_core_common headers propagate correctly

Verification

  • source /opt/ros/humble/setup.bash && colcon build --packages-select nebula_velodyne_common --symlink-install --mixin debug compile-commands coverage-gcc
  • source /opt/ros/humble/setup.bash && colcon test --packages-select nebula_velodyne_common --event-handlers console_direct+

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 40.33%. Comparing base (28d11ee) to head (359d18a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #429      +/-   ##
==========================================
+ Coverage   39.72%   40.33%   +0.60%     
==========================================
  Files         128      128              
  Lines       10018    10024       +6     
  Branches     4977     4984       +7     
==========================================
+ Hits         3980     4043      +63     
+ Misses       5443     5391      -52     
+ Partials      595      590       -5     
Flag Coverage Δ
nebula_velodyne_common 97.61% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mojomex mojomex marked this pull request as draft April 1, 2026 10:49
@mojomex mojomex self-assigned this Apr 1, 2026
@mojomex mojomex marked this pull request as ready for review April 1, 2026 15:37
@mojomex mojomex requested a review from drwnz April 2, 2026 08:51
Copy link
Copy Markdown
Collaborator

@drwnz drwnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great! The only ones that don't get tested here are failures in reading or writing the calibration file (bad file path, no file exists, malformed yaml). I don't know what the current actual behaviour is in this case, but a silent fail here is potentially a bad day for integration teams.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants