Skip to content

test: cover nebula_hesai_common helpers#427

Open
mojomex wants to merge 6 commits intotier4:mainfrom
mojomex:test/hesai-common-unit-coverage
Open

test: cover nebula_hesai_common helpers#427
mojomex wants to merge 6 commits intotier4:mainfrom
mojomex:test/hesai-common-unit-coverage

Conversation

@mojomex
Copy link
Copy Markdown
Collaborator

@mojomex mojomex commented Mar 31, 2026

Summary

  • add focused unit tests for nebula_hesai_common
  • cover PTP conversions, Hesai return-mode mappings, support predicates, and stream operators
  • wire the package into ament_cmake_gtest so the tests run in CI

Verification

  • source /opt/ros/humble/setup.bash && colcon build --packages-select nebula_hesai_common --symlink-install --mixin debug compile-commands coverage-gcc
  • source /opt/ros/humble/setup.bash && colcon test --packages-select nebula_hesai_common --event-handlers console_direct+

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.57%. Comparing base (ac59892) to head (fc87d34).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #427      +/-   ##
==========================================
+ Coverage   39.72%   47.57%   +7.84%     
==========================================
  Files         128      163      +35     
  Lines       10018    13302    +3284     
  Branches     4977     6964    +1987     
==========================================
+ Hits         3980     6328    +2348     
- Misses       5443     5588     +145     
- Partials      595     1386     +791     
Flag Coverage Δ
nebula_hesai_common 74.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mojomex mojomex marked this pull request as draft April 1, 2026 10:48
@mojomex mojomex marked this pull request as ready for review April 1, 2026 15:08
@mojomex mojomex requested a review from drwnz April 2, 2026 08:50
@mojomex mojomex self-assigned this Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant