fix: strengthen seed generation with crypto.getRandomValues()#229
Open
fix: strengthen seed generation with crypto.getRandomValues()#229
Conversation
Upgrade seedGen() to use the Web Crypto API for generating wallet seeds, providing cryptographically secure randomness via the OS entropy pool. Extract seed generation into a reusable utility with tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! Noticed that
seedGen()inCreateVaultComponentusesMath.random()for generating wallet seeds. Swapped it out forcrypto.getRandomValues()which pulls from the OS entropy pool — much better fit for a wallet context.Also extracted the logic into
src/app/utils/seed.utils.tsso it's reusable and testable, with a spec file covering length, character set, uniqueness, and that it's actually calling the crypto API.Note: the existing Karma test runner seems to have a bootstrapping issue (fails before any tests execute), so the spec couldn't be verified locally — but the build passes clean.
Small change, just the one function. Happy to adjust if needed!