fix: repair karma test runner and fix broken specs#230
Open
fix: repair karma test runner and fix broken specs#230
Conversation
Set allowJs: false in tsconfig.spec.json to work around a known Angular 16 karma builder issue with data URI compilation. Update AssetsComponent and NavigationComponent specs with proper test module imports and service mocks so all 15 tests pass.
Author
|
Worth noting — the tests added in #229 (seed generation) will also run correctly once this fix is in. Verified locally with both branches combined: 20 of 20 passing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! Noticed
yarn testwasn't working — the karma builder was failing before any tests could run.Root cause:
allowJs: trueintsconfig.jsontriggers a known Angular 16 karma builder bug where the test bootstrap data URI can't be compiled. SettingallowJs: falseintsconfig.spec.jsonfixes it (there are no.jsfiles insrc/anyway).Also updated the
AssetsComponentandNavigationComponentspecs — they were missing test module imports and service mocks, so they'd fail even once the runner was working. All 15 tests pass now.Ref: angular/angular-cli#25936