Skip to content

Fix Google ADK extension documentation and linting config#157

Merged
JesuTerraz merged 2 commits intousers/jterrazas/google-adk-supportfrom
copilot/sub-pr-156
Feb 3, 2026
Merged

Fix Google ADK extension documentation and linting config#157
JesuTerraz merged 2 commits intousers/jterrazas/google-adk-supportfrom
copilot/sub-pr-156

Conversation

Copy link
Contributor

Copilot AI commented Feb 3, 2026

Addresses review feedback on PR #156 for the Google ADK tooling extension.

Changes

  • Removed agentic_app_id from documentation - This parameter doesn't exist in add_tool_servers_to_agent(). It's derived internally via Utility.resolve_agent_identity(context, auth_token). Removed from both the example code and parameter table in design.md.

  • Added ruff copyright linting config - Missing [tool.ruff.lint.flake8-copyright] section in pyproject.toml, now consistent with other tooling extension packages.

Corrected Usage

# Before (incorrect)
agent = await service.add_tool_servers_to_agent(
    agent=existing_agent,
    agentic_app_id="your-agent-id",  # ❌ doesn't exist
    auth=auth_context,
    context=turn_context,
)

# After (correct)
agent = await service.add_tool_servers_to_agent(
    agent=existing_agent,
    auth=auth_context,
    auth_handler_name="graph",
    context=turn_context,
)

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: JesuTerraz <96103167+JesuTerraz@users.noreply.github.com>
Copilot AI changed the title [WIP] Add new Google ADK tooling extension Fix Google ADK extension documentation and linting config Feb 3, 2026
Copilot AI requested a review from JesuTerraz February 3, 2026 22:19
@JesuTerraz JesuTerraz marked this pull request as ready for review February 3, 2026 22:25
@JesuTerraz JesuTerraz requested a review from a team as a code owner February 3, 2026 22:25
@JesuTerraz JesuTerraz merged commit 5b58669 into users/jterrazas/google-adk-support Feb 3, 2026
1 check passed
@JesuTerraz JesuTerraz deleted the copilot/sub-pr-156 branch February 3, 2026 22:25
JesuTerraz added a commit that referenced this pull request Feb 6, 2026
* initial commit

* update pyproject.toml

* test additions

* remove non-central versioning

* format

* format x2

* ignore E402

* remove duplicate folder

* remove extra newline

* Fix Google ADK extension documentation and linting config (#157)

* Initial plan

* Fix design.md and add ruff copyright config per review comments

Co-authored-by: JesuTerraz <96103167+JesuTerraz@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: JesuTerraz <96103167+JesuTerraz@users.noreply.github.com>

* Align Google ADK extension with tooling extension conventions (#158)

* Initial plan

* Fix setup.py consistency and add @pytest.mark.unit decorators

Co-authored-by: JesuTerraz <96103167+JesuTerraz@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: JesuTerraz <96103167+JesuTerraz@users.noreply.github.com>

* Modify agent instead of creating a new instance

* Fix Google ADK extension documentation and log messages (#160)

* Initial plan

* Fix documentation and log message for in-place agent modification

Co-authored-by: JesuTerraz <96103167+JesuTerraz@users.noreply.github.com>

* Remove redundant comment from documentation example

Co-authored-by: JesuTerraz <96103167+JesuTerraz@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: JesuTerraz <96103167+JesuTerraz@users.noreply.github.com>

---------

Co-authored-by: Jesus Terrazas <jterrazas@microsoft.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants