New Google ADK Tooling Extension by JesuTerraz · Pull Request #156 · microsoft/Agent365-python

JesuTerraz · 2026-02-03T19:28:50Z

No description provided.

Copilot

Pull request overview

This pull request adds a new Google ADK (Agent Development Kit) tooling extension to the Agent365 Python SDK. The extension provides MCP (Model Context Protocol) tool registration capabilities for Google ADK-based agents, allowing them to dynamically discover and integrate MCP tool servers.

Changes:

Added new microsoft-agents-a365-tooling-extensions-google library package with MCP tool registration service
Implemented comprehensive unit tests covering initialization, tool server registration, error handling, and cleanup
Updated workspace configuration to include the new Google extension package

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`libraries/microsoft-agents-a365-tooling-extensions-google/microsoft_agents_a365/tooling/extensions/google/services/mcp_tool_registration_service.py`	Core service implementation for registering MCP tool servers with Google ADK agents
`libraries/microsoft-agents-a365-tooling-extensions-google/microsoft_agents_a365/tooling/extensions/google/services/__init__.py`	Service module exports
`libraries/microsoft-agents-a365-tooling-extensions-google/microsoft_agents_a365/tooling/extensions/google/__init__.py`	Package initialization and public API exports
`libraries/microsoft-agents-a365-tooling-extensions-google/setup.py`	Package build configuration with dynamic versioning
`libraries/microsoft-agents-a365-tooling-extensions-google/pyproject.toml`	Package metadata, dependencies, and tool configurations
`libraries/microsoft-agents-a365-tooling-extensions-google/README.md`	Package overview and documentation links
`libraries/microsoft-agents-a365-tooling-extensions-google/docs/design.md`	Architectural documentation and usage examples
`tests/tooling/extensions/google/test_mcp_tool_registration_service.py`	Comprehensive unit tests for the registration service
`tests/tooling/extensions/google/__init__.py`	Test package initialization
`pyproject.toml`	Added Google extension to workspace members and dependency constraints
`tests/RUNNING_TESTS.md`	Updated test installation instructions to include Google extension
`libraries/LICENSE.md`	MIT license file for the libraries directory

libraries/microsoft-agents-a365-tooling-extensions-google/docs/design.md

libraries/microsoft-agents-a365-tooling-extensions-googleadk/pyproject.toml

JesuTerraz · 2026-02-03T22:15:16Z

@copilot open a new pull request to apply changes based on the comments in this thread

Copilot · 2026-02-03T22:15:25Z

@JesuTerraz I've opened a new pull request, #157, to work on those changes. Once the pull request is ready, I'll request review from you.

* Initial plan * Fix design.md and add ruff copyright config per review comments Co-authored-by: JesuTerraz <96103167+JesuTerraz@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JesuTerraz <96103167+JesuTerraz@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

libraries/microsoft-agents-a365-tooling-extensions-google/setup.py

tests/tooling/extensions/google/test_mcp_tool_registration_service.py

JesuTerraz · 2026-02-03T22:37:22Z

@copilot open a new pull request to apply changes based on the comments in this thread

Copilot · 2026-02-03T22:37:31Z

@JesuTerraz I've opened a new pull request, #158, to work on those changes. Once the pull request is ready, I'll request review from you.

* Initial plan * Fix setup.py consistency and add @pytest.mark.unit decorators Co-authored-by: JesuTerraz <96103167+JesuTerraz@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JesuTerraz <96103167+JesuTerraz@users.noreply.github.com>

...microsoft_agents_a365/tooling/extensions/googleadk/services/mcp_tool_registration_service.py

rahuldevikar761

Create a workitem to validate if new package is being created and deployed. I don't recall on top of my head that we have a dynamic packaging blocked due to security reason.

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

libraries/microsoft-agents-a365-tooling-extensions-googleadk/docs/design.md

JesuTerraz · 2026-02-06T18:02:51Z

@copilot open a new pull request to apply changes based on the comments in this thread. Please be sure to find all google references that should be changed to googleadk

Copilot · 2026-02-06T18:03:03Z

@JesuTerraz I've opened a new pull request, #166, to work on those changes. Once the pull request is ready, I'll request review from you.

* Initial plan * Fix file structure path from google/ to googleadk/ in design.md Co-authored-by: JesuTerraz <96103167+JesuTerraz@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: JesuTerraz <96103167+JesuTerraz@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

...microsoft_agents_a365/tooling/extensions/googleadk/services/mcp_tool_registration_service.py

tests/tooling/extensions/googleadk/test_mcp_tool_registration_service.py

libraries/microsoft-agents-a365-tooling-extensions-googleadk/docs/design.md

Copilot

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.

...microsoft_agents_a365/tooling/extensions/googleadk/services/mcp_tool_registration_service.py

pyproject.toml

Copilot

Pull request overview

Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.

Copilot · 2026-02-06T19:22:59Z

...microsoft_agents_a365/tooling/extensions/googleadk/services/mcp_tool_registration_service.py

+        # Combine existing tools with new MCP servers
+        all_tools = list(agent.tools) + mcp_servers_info
+
+        self._logger.info(
+            f"Successfully configured agent with {len(mcp_servers_info)} MCP tool servers "
+            f"(total tools: {len(all_tools)})"
+        )
+
+        agent.tools = all_tools
+


add_tool_servers_to_agent() always appends toolsets for every server config without checking whether the agent already has a toolset for that server. If this method is called more than once for the same agent/context, it can create duplicate tools and duplicate entries in _connected_servers (and then attempt to close them multiple times during cleanup). Consider de-duping by server URL (or an explicit server identifier) before appending to agent.tools and _connected_servers.

@copilot open a new pull request to apply changes based on this feedback

Copilot · 2026-02-06T19:39:15Z

@JesuTerraz I've opened a new pull request, #168, to work on those changes. Once the pull request is ready, I'll request review from you.

Jesus Terrazas added 10 commits January 23, 2026 16:38

initial commit

26065ab

update pyproject.toml

1e191b4

test additions

76050f5

Merge branch 'main' into users/jterrazas/google-adk-support

a1f75ea

remove non-central versioning

e33a550

format

ab3e5d5

format x2

b52eb06

ignore E402

9c8264e

remove duplicate folder

80a96cb

remove extra newline

a9ecaeb

JesuTerraz marked this pull request as ready for review February 3, 2026 21:44

JesuTerraz requested review from a team as code owners February 3, 2026 21:44

JesuTerraz requested review from Copilot, mrunalhirve128 and pontemonti February 3, 2026 21:44

Copilot started reviewing on behalf of JesuTerraz February 3, 2026 21:44 View session

Copilot AI reviewed Feb 3, 2026

View reviewed changes

Copilot AI mentioned this pull request Feb 3, 2026

Fix Google ADK extension documentation and linting config #157

Merged

JesuTerraz requested a review from Copilot February 3, 2026 22:27

Copilot started reviewing on behalf of JesuTerraz February 3, 2026 22:27 View session

Copilot AI reviewed Feb 3, 2026

View reviewed changes

libraries/microsoft-agents-a365-tooling-extensions-google/setup.py Outdated Show resolved Hide resolved

tests/tooling/extensions/google/test_mcp_tool_registration_service.py Show resolved Hide resolved

Copilot AI mentioned this pull request Feb 3, 2026

Align Google ADK extension with tooling extension conventions #158

Merged

pontemonti reviewed Feb 4, 2026

View reviewed changes

...microsoft_agents_a365/tooling/extensions/googleadk/services/mcp_tool_registration_service.py Show resolved Hide resolved

Copilot started reviewing on behalf of JesuTerraz February 5, 2026 23:40 View session

rahuldevikar761 previously approved these changes Feb 5, 2026

View reviewed changes

Copilot AI reviewed Feb 5, 2026

View reviewed changes

libraries/microsoft-agents-a365-tooling-extensions-googleadk/docs/design.md Outdated Show resolved Hide resolved

pontemonti reviewed Feb 6, 2026

View reviewed changes

libraries/microsoft-agents-a365-tooling-extensions-googleadk/docs/design.md Outdated Show resolved Hide resolved

pontemonti previously approved these changes Feb 6, 2026

View reviewed changes

Copilot AI mentioned this pull request Feb 6, 2026

Fix file structure path in design.md from google/ to googleadk/ #166

Merged

JesuTerraz dismissed stale reviews from pontemonti and rahuldevikar761 via 4bbe9d4 February 6, 2026 18:11

JesuTerraz requested a review from Copilot February 6, 2026 18:11

Copilot started reviewing on behalf of JesuTerraz February 6, 2026 18:12 View session

Copilot AI reviewed Feb 6, 2026

View reviewed changes

Jesus Terrazas added 2 commits February 6, 2026 10:49

update to use url

975e822

test fix

391c7be

Copilot AI review requested due to automatic review settings February 6, 2026 18:55

Copilot started reviewing on behalf of JesuTerraz February 6, 2026 18:55 View session

Copilot AI reviewed Feb 6, 2026

View reviewed changes

...microsoft_agents_a365/tooling/extensions/googleadk/services/mcp_tool_registration_service.py Show resolved Hide resolved

pyproject.toml Show resolved Hide resolved

Jesus Terrazas added 2 commits February 6, 2026 11:15

update uv.lock

2a8b5c7

Merge branch 'main' into users/jterrazas/google-adk-support

ba4f87e

Copilot AI review requested due to automatic review settings February 6, 2026 19:17

Copilot started reviewing on behalf of JesuTerraz February 6, 2026 19:17 View session

Copilot AI reviewed Feb 6, 2026

View reviewed changes

Jesus Terrazas and others added 2 commits February 6, 2026 11:36

fixing uv lock to pass tests

e6ca941

Merge branch 'main' into users/jterrazas/google-adk-support

a3cbd62

Copilot AI review requested due to automatic review settings February 6, 2026 19:38

Copilot started reviewing on behalf of JesuTerraz February 6, 2026 19:38 View session

Copilot AI mentioned this pull request Feb 6, 2026

[WIP] WIP Address feedback on New Google ADK Tooling Extension PR #168

Draft

9 tasks

Conversation

JesuTerraz commented Feb 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JesuTerraz commented Feb 3, 2026

Uh oh!

Copilot AI commented Feb 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

JesuTerraz commented Feb 3, 2026

Uh oh!

Copilot AI commented Feb 3, 2026

Uh oh!

Uh oh!

rahuldevikar761 left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

JesuTerraz commented Feb 6, 2026

Uh oh!

Copilot AI commented Feb 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

JesuTerraz Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Feb 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants