Add caching to general_metadata to avoid repeated metadata parsing#1069
Open
vshnvii wants to merge 1 commit intomalariagen:masterfrom
Open
Add caching to general_metadata to avoid repeated metadata parsing#1069vshnvii wants to merge 1 commit intomalariagen:masterfrom
vshnvii wants to merge 1 commit intomalariagen:masterfrom
Conversation
vshnvii
force-pushed
the
add-sample-metadata-caching
branch
from
d1c588a to
629386e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces caching for general_metadata results to avoid repeated parsing
of metadata files when the same sample_sets are requested multiple times.
A cache dictionary (_cache_sample_metadata) is added and results are stored
using a tuple of sample_sets as the cache key.
This improves performance when metadata is accessed repeatedly during analysis.