Fix: use distance from boundbox edge for targeting distance#267
Open
TwinkNet wants to merge 5 commits intolambda-client:1.21.11from
Open
Fix: use distance from boundbox edge for targeting distance#267TwinkNet wants to merge 5 commits intolambda-client:1.21.11from
TwinkNet wants to merge 5 commits intolambda-client:1.21.11from
Conversation
emyfops
requested changes
Mar 13, 2026
Contributor
|
you need to account for AABB epsilon when calculating distance to closest AABB edge |
beanbag44
requested changes
Mar 17, 2026
| /** | ||
| * Returns the distance squared to the closest side of a [Box] | ||
| */ | ||
| fun Vec3d.distanceToSide(box: Box, epsilon: Double = 1e-7): Double { |
Member
There was a problem hiding this comment.
this seems to return a squared distance. Maybe a better name could be distToClosestPointSq? Or without the Sq if we square root it. Maybe another version of the function could be made for FastVector too to avoid the transformation in world utils
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently Lambda uses the
Entity.posto calculate distance from the player, which results in inconsistent targeting when fighting entities with large hitboxes, such as big slimes, ender dragons, and withers. I keep my targeting distance set to 3 blocks and there are certain mobs that it just won't hit unless i'm kissing them.This PR adds a helper function for calculating the distance from a
Vec3dto the closest side of aBox, and uses that function inWorldUtils.internalGetFastEntities()to calculate distance.Additionally,
fastEntitySearch()now accepts aFastVectorrather than aBlockPos, as I found that this helps achieve a bit more consistency in targeting when standing on the edge of a block.