Change dependency check order in cmake to enable build on OSX in CI#120
Merged
florent-lamiraux merged 1 commit intohumanoid-path-planner:develfrom Mar 25, 2026
Merged
Conversation
Contributor
|
Hello @ymontmarin. I was not aware that people were using HPP via conda. I removed the installation instructions because they were outdated. We can very well update and reintroduce them. |
florent-lamiraux
merged commit 8be1413
into
humanoid-path-planner:devel
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simple change in the cmake were needed to make the conda recipe work on OSX for conda: https://github.com/conda-forge/hpp-python-feedstock .
The new order follow the pattern in the other hpp packages.
But given this PR humanoid-path-planner/hpp-doc#190 maybe you don't want conda support anymore.
Still I know some people still use the
hpp-*package through conda.