Skip to content

fix: pass token correctly, '&' instead of ',' #1756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chandra-siri wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −3
Open

fix: pass token correctly, '&' instead of ',' #1756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
24fc906
fix: pass token correctly, '&' instead of ','
chandra-siri Feb 20, 2026
dece2f7
remove reversed
chandra-siri Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion google/cloud/storage/asyncio/async_appendable_object_writer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ async def _do_open():
)

await self.write_obj_stream.open(
metadata=current_metadata if metadata else None
metadata=current_metadata if current_metadata else None
)

if self.write_obj_stream.generation_number:
Expand Down
2 changes: 1 addition & 1 deletion google/cloud/storage/asyncio/async_read_object_stream.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ async def open(self, metadata: Optional[List[Tuple[str, str]]] = None) -> None:
other_metadata.append((key, value))

current_metadata = other_metadata
current_metadata.append(("x-goog-request-params", ",".join(request_params)))
current_metadata.append(("x-goog-request-params", "&".join(request_params)))

self.socket_like_rpc = AsyncBidiRpc(
self.rpc,
Expand Down
2 changes: 1 addition & 1 deletion google/cloud/storage/asyncio/async_write_object_stream.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ async def open(self, metadata: Optional[List[Tuple[str, str]]] = None) -> None:
else:
final_metadata.append((key, value))

final_metadata.append(("x-goog-request-params", ",".join(request_param_values)))
final_metadata.append(("x-goog-request-params", "&".join(request_param_values)))

self.socket_like_rpc = AsyncBidiRpc(
self.rpc,
Expand Down