Skip to content

fix: pass token correctly, '&' instead of ','#1756

Open
chandra-siri wants to merge 2 commits intomainfrom
pass_routing_token_correctly
Open

fix: pass token correctly, '&' instead of ','#1756
chandra-siri wants to merge 2 commits intomainfrom
pass_routing_token_correctly

Conversation

@chandra-siri
Copy link
Collaborator

fix: pass token correctly, '&' instead of ','

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: storage Issues related to the googleapis/python-storage API. labels Feb 20, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @chandra-siri, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where x-goog-request-params were being incorrectly formatted with a comma separator instead of an ampersand, which is crucial for the proper transmission and parsing of request parameters, including tokens, in asynchronous Google Cloud Storage operations. Additionally, it includes a minor logical correction to ensure the correct metadata variable is utilized during object writing.

Highlights

  • Parameter Separator Fix: Corrected the separator for x-goog-request-params from a comma (,) to an ampersand (&) in both async_read_object_stream.py and async_write_object_stream.py to ensure proper parameter parsing.
  • Parameter Order Adjustment: Reversed the order of request parameters when joining them with '&' in async_read_object_stream.py for correct server-side interpretation.
  • Metadata Variable Correction: Ensured the correct current_metadata variable is referenced when opening the write stream in async_appendable_object_writer.py.
Changelog
  • google/cloud/storage/asyncio/async_appendable_object_writer.py
    • Fixed a logical error by changing the metadata variable from metadata to current_metadata when opening the write stream.
  • google/cloud/storage/asyncio/async_read_object_stream.py
    • Updated the x-goog-request-params header to use '&' as a separator instead of ',' for joining request parameters.
    • Reversed the order of request_params before joining them with '&'.
  • google/cloud/storage/asyncio/async_write_object_stream.py
    • Modified the x-goog-request-params header to use '&' as a separator instead of ',' for joining request parameters.
Activity
  • No specific activity has been recorded for this pull request since its creation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request correctly addresses the issue of using the wrong separator for x-goog-request-params and fixes a logic error in AsyncAppendableObjectWriter where routing tokens were being ignored during stream re-opening. I have one comment regarding an inconsistency in how parameters are joined in async_read_object_stream.py.

reversed not needed

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@chandra-siri chandra-siri marked this pull request as ready for review February 20, 2026 11:14
@chandra-siri chandra-siri requested review from a team as code owners February 20, 2026 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/python-storage API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments