fix(mise): auto-install minimum version configured in mise.toml#1111
Open
fix(mise): auto-install minimum version configured in mise.toml#1111
Conversation
Base automatically changed from
malept/fix/ci-machine-reduce-network-calls
to
main
March 17, 2026 08:51
ekalinichev
approved these changes
Mar 17, 2026
Contributor
|
Link to code coverage report (posted by coverbot 🤖) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
When
min_version.hardis set in a project'smise.toml,ensure_mise_installednow automatically upgrades mise if the installed version is below the configured minimum. This prevents CI failures and confusing errors when a project requires a newer mise version than what's installed on the worker.Also:
mise_version()andmise_version_compatible()functions, replacing the previousgojq-based parsing (which could fail if mise was too old to run the project config)wc -coutput included the filename, breaking the empty-file check for the cached install scriptensure_mise_installedbeforebootstrap_github_tokeninsetup.shso mise is available at the very start of CI setupJira ID
DT-5166
Notes for your reviewers
min_version.hardis not set inmise.toml(the current default), behavior is unchangedinstall_misenow accepts an optional version parameter; the apt fallback cannot install a specific version and will warn accordinglymise_version()deliberately avoids JSON+gojq since gojq is mise-installed and may not be available when the installed mise is too old for the project config due to chicken-and-egg dependenciesTODO
Note
This is a draft because it depends on #1110. It should be reviewable otherwise.
mainRovo Dev code review: Out of Rovo Dev credits
You've used all your Rovo Dev credits, so Rovo Dev can't review your pull requests.