chore: deprecate assignUniqueLabels#158
Conversation
sbillinge
left a comment
There was a problem hiding this comment.
I will merge this but @stevenhua0320 and @cadenmyers13 please can you see my comment
| @@ -0,0 +1,23 @@ | |||
| **Added:** | |||
|
|
|||
| * No News Added: deprecate assignUniqueLabels method | |||
There was a problem hiding this comment.
Why is this no news. Don't we need to list what we deprecate and what we add?
tests/test_structure.py
Outdated
|
|
||
| def test_assignUniqueLabels(self): | ||
| """Check Structure.assignUniqueLabels()""" | ||
| """Duplicate test with the deprecated assignUniqueLabels method. |
There was a problem hiding this comment.
I don't think we need to do this. This test will start failing when we remove the function so these will be easy to find and remove.
There was a problem hiding this comment.
@sbillinge So, what we need to contain here? should we maintain the original docstring here?
|
Actually, I can't merge because of the news. I am afraid that I may have merged som no-news's that should have had news in them. Please can you take a look @stevenhua0320 and add PRs if I did? |
|
@sbillinge It's safe right now since nothing deprecation's PR has been merged yet. I would now change the news and see anything that we need edit here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #158 +/- ##
=======================================
Coverage 98.93% 98.93%
=======================================
Files 13 13
Lines 1878 1884 +6
=======================================
+ Hits 1858 1864 +6
Misses 20 20
🚀 New features to boost your workflow:
|
@sbillinge ready to review.
Now the test for this function would give
deprecationWarningshown below.