Skip to content

Comments

build: deprecate assignUniqueLabels#160

Closed
stevenhua0320 wants to merge 6 commits intodiffpy:v3.4.0from
stevenhua0320:deprecate-assignUniqueLabels
Closed

build: deprecate assignUniqueLabels#160
stevenhua0320 wants to merge 6 commits intodiffpy:v3.4.0from
stevenhua0320:deprecate-assignUniqueLabels

Conversation

@stevenhua0320
Copy link
Contributor

@stevenhua0320 stevenhua0320 commented Feb 20, 2026

@sbillinge ready to review. I realized that I merged to the wrong branch on upstream. It should be v3.4.0 instead of main branch. We should do a revert on the main for PR #158 .

@codecov
Copy link

codecov bot commented Feb 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.95%. Comparing base (52c99e6) to head (3e092b1).
⚠️ Report is 7 commits behind head on v3.4.0.

Additional details and impacted files
@@           Coverage Diff           @@
##           v3.4.0     #160   +/-   ##
=======================================
  Coverage   98.95%   98.95%           
=======================================
  Files          13       13           
  Lines        1905     1911    +6     
=======================================
+ Hits         1885     1891    +6     
  Misses         20       20           
Files with missing lines Coverage Δ
tests/test_structure.py 99.79% <100.00%> (+<0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sbillinge
Copy link
Contributor

@cadenmyers13 @stevenhua0320 thanks for catching this.

I suggest that we don't do this work. We can either merge main into v3.4.0 if no other work has been done on main, or maybe better, just do nothing and it will all merge up when we do the final merge to main. We just need to remember which functions were incorrectly merged and not be tempted to do them over again....

@cadenmyers13
Copy link
Contributor

@stevenhua0320 I would try to merge main into v3.4.0 if you can because having to remember will be tough. If the merge is challenging (ie lots of merge conflicts) try manually making the changes on v3.4.0. It might lead to minor merge conflicts when we eventually merge v3.4.0 into main but overall I think that would be an easier fix than having to remember later

@sbillinge
Copy link
Contributor

Can we close this PR so it doesn't accidentally get merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants