DAOS-18728 pool: not bump pool_component::co_in_ver when UP to UPIN#17772
Draft
DAOS-18728 pool: not bump pool_component::co_in_ver when UP to UPIN#17772
Conversation
|
Ticket title is 'pool_component::co_in_ver dump after rebuild may cause DTX leader election failure' |
Collaborator
|
Test stage Unit Test completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17772/1/testReport/ |
Nasf-Fan
force-pushed
the
Nasf-Fan/DAOS-18728_1
branch
2 times, most recently
from
1bc5310 to
23d877c
Compare
Collaborator
|
Test stage Unit Test completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17772/3/testReport/ |
The pool_component::co_in_ver is used to record the pool map version when the target status (co_status) is set as UP. Do not bump it when be changed from UP to UPIN. Otherwise, it will misguide DTX logic as to DTX resync may leak DTX entry. Another fix is for DTX logic: only UPIN target can be as DTX leader. Signed-off-by: Fan Yong <fan.yong@hpe.com>
Nasf-Fan
force-pushed
the
Nasf-Fan/DAOS-18728_1
branch
from
23d877c to
a4af12b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pool_component::co_in_ver is used to record the pool map version when the target status (co_status) is set as UP. Do not bump it when be changed from UP to UPIN. Otherwise, it will misguide DTX logic as to DTX resync may leak DTX entry.
Another fix is for DTX logic: only UPIN target can be as DTX leader.
Steps for the author:
After all prior steps are complete: