Prevent Syncthing from starting when storage permissions are denied#88
Merged
chenxiaolong merged 1 commit intomasterfrom Apr 7, 2026
Merged
Prevent Syncthing from starting when storage permissions are denied#88chenxiaolong merged 1 commit intomasterfrom
chenxiaolong merged 1 commit intomasterfrom
Conversation
When storage permissions are disabled, Android still makes the directory structure visible. Since Syncthing can access all of the shared folders and their .stfolder markers, it thinks that all of the files were deleted. We can avoid potential data loss by preventing Syncthing from starting at all when storage permissions are denied. We do not need to worry about permission revocation because Android always kills the app when that happens. Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
chenxiaolong
added a commit
that referenced
this pull request
Apr 7, 2026
Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When storage permissions are disabled, Android still makes the directory structure visible. Since Syncthing can access all of the shared folders and their
.stfoldermarkers, it thinks that all of the files were deleted.We can avoid potential data loss by preventing Syncthing from starting at all when storage permissions are denied. We do not need to worry about permission revocation because Android always kills the app when that happens.