Update 'tstart' in 'shift' method if present and unit test#971
Merged
matteobachetti merged 3 commits intoStingraySoftware:mainfrom Mar 16, 2026
Merged
Update 'tstart' in 'shift' method if present and unit test#971matteobachetti merged 3 commits intoStingraySoftware:mainfrom
matteobachetti merged 3 commits intoStingraySoftware:mainfrom
Conversation
matteobachetti
approved these changes
Mar 16, 2026
Member
matteobachetti
left a comment
matteobachetti
left a comment
There was a problem hiding this comment.
LGTM! Thanks @swapsha96
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant Issue(s)/PR(s)
Fixes #911
Provide an overview of the implemented solution or the fix and elaborate on the modifications.
When timeseries is shifted (Github issue takes example of Lightcurve), time and GTIs are shifted however shifting
tstartis missed which is address by this PR.I've also updated existing unit test as well
Is there a new dependency introduced by your contribution? If so, please specify.
No
Any other comments?
No