Fix lc.shift() not updating tstart attribute#967
Closed
anuragchvn-blip wants to merge 1 commit intoStingraySoftware:mainfrom
Closed
Fix lc.shift() not updating tstart attribute#967anuragchvn-blip wants to merge 1 commit intoStingraySoftware:mainfrom
anuragchvn-blip wants to merge 1 commit intoStingraySoftware:mainfrom
Conversation
Fixes StingraySoftware#911. The shift method in Lightcurve now properly updates the tstart attribute to remain consistent with the shifted time array. The fix overrides the parent shift method to recalculate tstart after shifting, ensuring tstart = time[0] - 0.5 * dt as expected.
Member
|
Thanks for your contribution @anuragchvn-blip , but @swapsha96 's solution in #971 is more elegant, and he tested the new feature properly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant Issue(s)/PR(s)
Fixes #911
Provide an overview of the implemented solution
The
Lightcurve.shift()method now properly updates thetstartattribute after shifting. Previously,tstartremained unchanged after callingshift(), causing inconsistency betweentstartand the actualtime[0] - 0.5 * dt.The fix overrides the parent
shift()method to recalculatetstartafter the time array is shifted.Is there a new dependency introduced by your contribution?
No
Any other comments?
dtvaluesinplace=Trueandinplace=False