Skip to content

Fix external URL handler signature in main.dev.js #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hellosamyak wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix external URL handler signature in main.dev.js #376

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/main.dev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,11 +128,11 @@ const createWindow = async () => {

// Shared handler to take a URL and determine if we should open it in the user's
// browser (returns true), or if we let electron handle it normally (false).
async function handleUrl(url: string) {
function handleUrl(url) {
try {
const parsedUrl = new URL(url);
const { protocol } = parsedUrl;
if (protocol === "http:" || protocol === "https:") {
if (protocol === 'http:' || protocol === 'https:') {
shell.openExternal(url); // Open in external browser
return true;
}
Expand Down