Fix external URL handler signature in main.dev.js#376
Fix external URL handler signature in main.dev.js#376hellosamyak wants to merge 1 commit intoStatTag:masterfrom
Conversation
|
@lrasmus could you please take a look at this small fix PR when you get a chance? |
|
@hellosamyak - I am curious when you got the javascript compile error? I do not recall seeing that on my end. Did the function not work when you were testing it? I just want to understand exactly the steps to reproduce the problem so that I can make a note to similarly test in the future. |
|
@lrasmus Hi Luke, thanks for asking. I should clarify: I did not hit a webpack/electron build failure from this change while running yarn dev. The app still launched. Repro steps I used:
Runtime note:
So the fix was mainly to remove editor/type-check noise and align the handler behavior with how it is consumed. |
Summary:
Remove accidental TypeScript annotation from JavaScript file and make URL handler synchronous for correct use in setWindowOpenHandler.
Why:
The previous function signature caused JS compile errors, and async returned a Promise where a boolean was expected.
File:
app/main.dev.js