Skip to content

Citing SasModels and SasData#32

Open
krzywon wants to merge 1 commit intomasterfrom
citation-information
Open

Citing SasModels and SasData#32
krzywon wants to merge 1 commit intomasterfrom
citation-information

Conversation

@krzywon
Copy link
Copy Markdown
Contributor

@krzywon krzywon commented Apr 9, 2026

This updates our citation site with information on citing and/or acknowledging sasmodels and sasdata.

Copy link
Copy Markdown

@DrPaulSharp DrPaulSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good to me.

Comment on lines +55 to +56
> P. Kienzle, et. al., SasModels (2016), https://github.com/SasView/sasmodels

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using (2016) seems totally gratuitous (and actually wrong) given for example the version 1.0.12 was released in Dec of 2025! why not just include the version number as we do with the sasview GUI package ( P. Kienzel, et al., sasmodels Version 1.0.12, https://githbu.com/SasView/sasmodels)?

Comment on lines +61 to +62
> J. Krzywon, et. al. SasData (2022), https://github.com/SasView/sasdata

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as for sasmodels. 2022 is clearly incorrect. a version number however would be helpful I would think?

Comment on lines 14 to 15
Each release of SasView is given a unique DOI. As new versions are released, calculation methods may change or be corrected.
To account for these calculation differences, please cite the version or versions you used to analyze your data.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like it should be part of the preamble not part of citing sasview specifically. calculation in sasmodels and sasdata can change with versions as well and is why it is important to know the version used. This is known to be important for sasmodels where there have been errors in models that have been corrected (e.g. the paracrystal models)

If you found this software useful to your work please cite and/or acknowledge its use in your publications.
If you found this software useful to your work please cite and/or [acknowledge](#acknowledging-sasview) its use in your publications.

Users who utilized the SasView GUI need only cite [SasView](#citing-sasview). Users who integrated packages
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering about the wording 'SasView GUI' and whether 'GUI-driven SasView' would be better?

### Acknowledging SasView

If you would like to acknowledge SasView, please include the following:
If you would like to acknowledge the use of one or more sasview software packages, please include the following:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'sasview' should be 'SasView'.

Copy link
Copy Markdown
Contributor

@smk78 smk78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of minor comments, and agree with @butlerpd 's first comment. But othe rthan that LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants