[19.0][MIG] agreement: Migration to 19.0 by Vang-NguyenPhu · Pull Request #99 · OCA/agreement

Vang-NguyenPhu · 2026-01-15T08:03:42Z

No description provided.

we move the is_template field definition and the agreement.type model from the agreement_legal module to the agreement module. The fields are not displayed by default, unless the feature is enabled through a technical feature group, this is configurable in the agreement_sale module (because agreement in itself has no UI, and agreement_legal enables the feature by default)

- The `agreement` model now features mail and activities from its base module. - The `agreement_legal` module doesn't need to add mail support now. - Add activities to form views. @Tecnativa TT22477

Update agreement and agreement_sale to restore the behavior of v10

…ad of onchange field

Co-authored-by: Denis Roussel (ACSONE) <rousseldenis@users.noreply.github.com>

Currently translated at 100.0% (64 of 64 strings) Translation: agreement-17.0/agreement-17.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-17-0/agreement-17-0-agreement/it/

Currently translated at 100.0% (66 of 66 strings) Translation: agreement-17.0/agreement-17.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-17-0/agreement-17-0-agreement/it/

leemannd · 2026-01-15T13:23:26Z

/ocabot migration agreement

leemannd · 2026-01-15T13:27:34Z

Hello @Vang-NguyenPhu , Is it possible to reduce the commit history by following -> https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0
Also I am expecting to have at least two migration commits:

pre-commit
a migration commit

Currently translated at 100.0% (72 of 72 strings) Translation: agreement-18.0/agreement-18.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement/sv/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: agreement-18.0/agreement-18.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement/

Currently translated at 100.0% (74 of 74 strings) Translation: agreement-18.0/agreement-18.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement/it/

Currently translated at 100.0% (74 of 74 strings) Translation: agreement-18.0/agreement-18.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement/sv/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: agreement-18.0/agreement-18.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement/

Currently translated at 100.0% (73 of 73 strings) Translation: agreement-18.0/agreement-18.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement/it/

Vang-NguyenPhu · 2026-01-21T07:55:01Z

Hello @Vang-NguyenPhu , Is it possible to reduce the commit history by following -> https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0 Also I am expecting to have at least two migration commits:

pre-commit

a migration commit

I rebased some Bot's commit.
Actually, there is nothing to commit at the first pre-commit

CRogos · 2026-01-21T18:26:27Z

Currently agreement and agreement_legal is a little confusing. Especially the Form, which is in agreement_legal not reused.

Maybe we can change agreement a little bit so that the extensions can more easily link in?

Add a group "Gernal" and "Term Dates" in module agreement
Maybe move some attributes to agreement_legacy when they are hidden by agreement_legal?

In agreement_legal there is already a roadmap what should be changed.

We are not yet using agreement but are interested. Currently there is a lot of stuff we don't need and would like to hide (or better not install).

cc: @MohamedOsman7

gdgellatly · 2026-03-03T22:05:39Z

Currently agreement and agreement_legal is a little confusing. Especially the Form, which is in agreement_legal not reused.

Maybe we can change agreement a little bit so that the extensions can more easily link in?

Add a group "Gernal" and "Term Dates" in module agreement

Maybe move some attributes to agreement_legacy when they are hidden by agreement_legal?

In agreement_legal there is already a roadmap what should be changed.
We are not yet using agreement but are interested. Currently there is a lot of stuff we don't need and would like to hide (or better not install).

cc: @MohamedOsman7

Honestly, I am dead against this. The current layout works really well for agreement and agreement_rebate. I think if agreement_legal needs something special then make xpath selection easier to move but don't break the layout to suit one module.

gdgellatly

Notwithstanding the process nitpicks mentioned, functionally this module is working as expected. Tested in combination with #108 and own internal work with a test suite of nearly 250 unit and integration tests, plus manual work. Worked perfect.

huan-tq

Functional tested and it's LGTM.

OCA-git-bot · 2026-03-06T10:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

CRogos

Could you squash some of the commits?

https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate

ygol and others added 24 commits January 15, 2026 14:59

[MIG] agreement: Migration to 12.0

13b5bdb

FIX security issue + details

8ae65f3

[FIX] Missing newline

6e9b65a

[IMP] agreement,agreement_legal: support activities

87ed16f

- The `agreement` model now features mail and activities from its base module. - The `agreement_legal` module doesn't need to add mail support now. - Add activities to form views. @Tecnativa TT22477

[IMP] agreement: Minor improvements

3625dad

Re-introduce module agreement_account

054a7d2

Update agreement and agreement_sale to restore the behavior of v10

[IMP] agreement: black, isort, prettier

f6d06e7

[MIG] agreement: Migration to 13.0

f69508e

[IMP] agreement: black, isort, prettier

0d7eb82

[MIG] agreement: Migration to 14.0

d169adc

[IMP] agreement: black, isort, prettier

a8f3af7

[MIG] agreement: Migration to 15.0

239b7bf

[IMP] agreement: Change menus structure to make it easy to adapt

ac6a7c5

[MIG] agreement: Migration to 16.0

5638cdc

[IMP] agreement - Change domain field into computed store field inste…

b2a7e21

…ad of onchange field

[IMP] agreement: pre-commit auto fixes

863dda0

[MIG] agreement: Migration to 17.0

d1c0ac2

Update agreement/models/agreement.py

cbec23f

Co-authored-by: Denis Roussel (ACSONE) <rousseldenis@users.noreply.github.com>

Translated using Weblate (Italian)

3afa5e1

Currently translated at 100.0% (64 of 64 strings) Translation: agreement-17.0/agreement-17.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-17-0/agreement-17-0-agreement/it/

Translated using Weblate (Italian)

fd2648e

Currently translated at 100.0% (66 of 66 strings) Translation: agreement-17.0/agreement-17.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-17-0/agreement-17-0-agreement/it/

Translated using Weblate (Italian)

9e61c67

Currently translated at 100.0% (66 of 66 strings) Translation: agreement-17.0/agreement-17.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-17-0/agreement-17-0-agreement/it/

[IMP] agreement: pre-commit execution

2c947a6

[MIG] agreement: Migration to 18.0

820f056

Vang-NguyenPhu force-pushed the 19.0-mig-agreement branch 2 times, most recently from 6540d3e to 6f1b2e5 Compare January 15, 2026 08:43

Vang-NguyenPhu mentioned this pull request Jan 15, 2026

Migration to version 19.0 #90

Open

5 tasks

OCA-git-bot added this to the 19.0 milestone Jan 15, 2026

jakobkrabbe and others added 16 commits January 21, 2026 14:52

Translated using Weblate (Swedish)

6fa1c81

Currently translated at 100.0% (72 of 72 strings) Translation: agreement-18.0/agreement-18.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement/sv/

Translated using Weblate (Swedish)

8a0e436

Currently translated at 100.0% (72 of 72 strings) Translation: agreement-18.0/agreement-18.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement/sv/

[MOV] agreement_legal > agreement: res.partner.agreement_[ids|count]

33bb06d

[UPD] Update agreement.pot

4a12a21

Update translation files

cfe1f20

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: agreement-18.0/agreement-18.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement/

Translated using Weblate (Italian)

f4fdf7c

Currently translated at 100.0% (74 of 74 strings) Translation: agreement-18.0/agreement-18.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement/it/

Translated using Weblate (Swedish)

b377fe3

Currently translated at 100.0% (74 of 74 strings) Translation: agreement-18.0/agreement-18.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement/sv/

[UPD] Update agreement.pot

e61565c

Update translation files

3434527

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: agreement-18.0/agreement-18.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement/

[UPD] Update agreement.pot

48ebc3e

Update translation files

d6b5eef

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: agreement-18.0/agreement-18.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement/

[UPD] Update agreement.pot

63feab6

[UPD] Update agreement.pot

6dd19be

Update translation files

d3a38a9

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: agreement-18.0/agreement-18.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement/

Translated using Weblate (Italian)

977a8ac

Currently translated at 100.0% (73 of 73 strings) Translation: agreement-18.0/agreement-18.0-agreement Translate-URL: https://translation.odoo-community.org/projects/agreement-18-0/agreement-18-0-agreement/it/

[MIG] agreement: Migration to 19.0

8f1b55a

Vang-NguyenPhu force-pushed the 19.0-mig-agreement branch from 6f1b2e5 to 8f1b55a Compare January 21, 2026 07:52

Vang-NguyenPhu mentioned this pull request Feb 4, 2026

[19.0][MIG] agreement_sale: Migration to 19.0 #100

Open

gdgellatly mentioned this pull request Feb 28, 2026

[19.0][MIG] agreement_rebate: Migration to 19.0 #108

Open

3 tasks

gdgellatly approved these changes Mar 3, 2026

View reviewed changes

huan-tq approved these changes Mar 6, 2026

View reviewed changes

OCA-git-bot added approved ready to merge labels Mar 6, 2026

yankinmax mentioned this pull request Mar 13, 2026

[19.0][MIG] agreement_rebate_partner_company_group: Migration to 19.0 OCA/contract#1405

Open

2 tasks

ivantodorovich approved these changes Mar 17, 2026

View reviewed changes

CRogos reviewed Mar 18, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[19.0][MIG] agreement: Migration to 19.0#99

[19.0][MIG] agreement: Migration to 19.0#99
Vang-NguyenPhu wants to merge 56 commits intoOCA:19.0from
komit-consulting:19.0-mig-agreement

Vang-NguyenPhu commented Jan 15, 2026

Uh oh!

leemannd commented Jan 15, 2026

Uh oh!

leemannd commented Jan 15, 2026

Uh oh!

Vang-NguyenPhu commented Jan 21, 2026

Uh oh!

CRogos commented Jan 21, 2026

Uh oh!

gdgellatly commented Mar 3, 2026

Uh oh!

gdgellatly left a comment

Uh oh!

huan-tq left a comment

Uh oh!

OCA-git-bot commented Mar 6, 2026

Uh oh!

CRogos left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Conversation

Vang-NguyenPhu commented Jan 15, 2026

Uh oh!

leemannd commented Jan 15, 2026

Uh oh!

leemannd commented Jan 15, 2026

Uh oh!

Vang-NguyenPhu commented Jan 21, 2026

Uh oh!

CRogos commented Jan 21, 2026

Uh oh!

gdgellatly commented Mar 3, 2026

Uh oh!

gdgellatly left a comment

Choose a reason for hiding this comment

Uh oh!

huan-tq left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Mar 6, 2026

Uh oh!

CRogos left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants