[19.0][MIG] agreement_sale: Migration to 19.0#100
[19.0][MIG] agreement_sale: Migration to 19.0#100Vang-NguyenPhu wants to merge 25 commits intoOCA:19.0from
Conversation
Vang-NguyenPhu
force-pushed
the
19.0-mig-agreement_sale
branch
from
d37cb6f to
b59b0ab
Compare
|
Hello @Vang-NguyenPhu is it possible to squash a bit the translation/administrative commits? |
we move the is_template field definition and the agreement.type model from the agreement_legal module to the agreement module. The fields are not displayed by default, unless the feature is enabled through a technical feature group, this is configurable in the agreement_sale module (because agreement in itself has no UI, and agreement_legal enables the feature by default)
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: contract-14.0/contract-14.0-agreement_sale Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-agreement_sale/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: agreement-17.0/agreement-17.0-agreement_sale Translate-URL: https://translation.odoo-community.org/projects/agreement-17-0/agreement-17-0-agreement_sale/
Vang-NguyenPhu
force-pushed
the
19.0-mig-agreement_sale
branch
from
b59b0ab to
5d4bfbc
Compare
All good now, please help to review. Thank you @leemannd |
Vang-NguyenPhu
force-pushed
the
19.0-mig-agreement_sale
branch
from
5d4bfbc to
231eef2
Compare
|
Hi @leemannd Do you know how to fix this error? It seems like OCA changed the behavior of adding depends PR, right? Could you please guide me on how to fix this? Thank you. 
|
|
Hello, this is due because you depend on a non merged PR. You should add a There is an example in -> OCA/delivery-carrier@c9f657b |
Vang-NguyenPhu
force-pushed
the
19.0-mig-agreement_sale
branch
3 times, most recently
from
e2ba0ff to
7a7ef49
Compare
Vang-NguyenPhu
force-pushed
the
19.0-mig-agreement_sale
branch
from
7a7ef49 to
c8233d0
Compare
Quan-nhm
left a comment
Quan-nhm
left a comment
There was a problem hiding this comment.
It's LGTM for functional test and code review. but it would be greate if you could refactor the comment as well.
| action = self.env["ir.actions.act_window"]._for_xml_id( | ||
| "sale.action_quotations" | ||
| ) |
There was a problem hiding this comment.
Can we move it outside of the loop?
action = self.env["ir.actions.act_window"]._for_xml_id( "sale.action_quotations" )
| "sale.action_quotations" | ||
| ) | ||
| if len(sale_order_ids) == 1: | ||
| action["views"] = [(self.env.ref("sale.view_order_form").id, "form")] |
There was a problem hiding this comment.
Can we have this outside of the loop as well? self.env.ref("sale.view_order_form")
17 participants
Depends on: