Add NUnit migration tests for NestedContentMigratingConfig#905
Merged
KevinJump merged 3 commits intov17/nested-contentfrom Mar 4, 2026
Merged
Add NUnit migration tests for NestedContentMigratingConfig#905KevinJump merged 3 commits intov17/nested-contentfrom
KevinJump merged 3 commits intov17/nested-contentfrom
Conversation
Merged
Co-authored-by: KevinJump <431231+KevinJump@users.noreply.github.com>
Co-authored-by: KevinJump <431231+KevinJump@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] WIP Address feedback from review on V17 nested content PR
Add NUnit migration tests for NestedContentMigratingConfig
Mar 4, 2026
KevinJump
added a commit
that referenced
this pull request
Mar 4, 2026
* Add support for direct migration of nested content to blocklist. (as part of a sync). * media item - logging parent fail * Update uSync.Core/Serialization/Serializers/MediaSerializer.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Update uSync.Core/Mapping/Mappers/NestedContentToBlockListHelper.cs Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * Use OfType instead of Cast when iterating nested content config array (#904) * Initial plan * Use OfType instead of Cast for resilience to non-object array entries Co-authored-by: KevinJump <431231+KevinJump@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: KevinJump <431231+KevinJump@users.noreply.github.com> * Add NUnit migration tests for NestedContentMigratingConfig (#905) * Initial plan * Fix MediaSerializer build error and plan nested content migration tests Co-authored-by: KevinJump <431231+KevinJump@users.noreply.github.com> * Add NUnit migration tests for NestedContentMigratingConfig Co-authored-by: KevinJump <431231+KevinJump@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: KevinJump <431231+KevinJump@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com> Co-authored-by: KevinJump <431231+KevinJump@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NestedContentMigratingConfig(Nested Content → Block List migration) lacked test coverage. This PR adds NUnit migration tests consistent with the existing test patterns in the repo.Tests added (
NestedContentMigrationTests.cs)minItems,maxItems, multiplecontentTypes→validationLimit+blocksarrayIContentTypeService.Get()returningnullomits that blockBlockConfigurationentriescontentTypes— results innullblocks (documents actual serialization pipeline behavior:JsonObjectConverterdeserializes empty arrays asnullwhen target type isobject)Bug fix
MediaSerializer.cshad a compile error introduced in a prior commit:parentIdwas declared inside atryblock but referenced in thecatchclause. Reverted toparent?.Id.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.