Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds migration support so legacy Nested Content datatypes and stored Nested Content property values can be converted to Block List during import (e.g., importing v13 uSync files into v17+).
Changes:
- Run datatype configuration serializers based on the source editor alias from the import XML (enabling legacy-alias migrations).
- Add Nested Content → Block List configuration migration serializer.
- Add Nested Content → Block List value conversion when a Block List value cannot be parsed during block-value processing.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| uSync.Core/Serialization/Serializers/MediaSerializer.cs | Adds logging around media creation failures. |
| uSync.Core/Serialization/Serializers/DataTypeSerializer.cs | Uses the imported editor alias when selecting config serializers to support legacy migrations. |
| uSync.Core/Mapping/SyncBlockMapperBase.cs | Falls back to converting Nested Content JSON into Block List JSON when block JSON can’t be parsed. |
| uSync.Core/Mapping/Mappers/NestedContentToBlockListHelper.cs | Implements Nested Content value → Block List value conversion helper. |
| uSync.Core/DataTypes/DataTypeSerializers/NestedContentMigratingConfig.cs | Implements Nested Content datatype config → Block List config migration. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
uSync.Core/DataTypes/DataTypeSerializers/NestedContentMigratingConfig.cs
Show resolved
Hide resolved
uSync.Core/DataTypes/DataTypeSerializers/NestedContentMigratingConfig.cs
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
|
@KevinJump I've opened a new pull request, #904, to work on those changes. Once the pull request is ready, I'll request review from you. |
Contributor
|
@KevinJump I've opened a new pull request, #905, to work on those changes. Once the pull request is ready, I'll request review from you. |
…#904) * Initial plan * Use OfType instead of Cast for resilience to non-object array entries Co-authored-by: KevinJump <431231+KevinJump@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: KevinJump <431231+KevinJump@users.noreply.github.com>
* Initial plan * Fix MediaSerializer build error and plan nested content migration tests Co-authored-by: KevinJump <431231+KevinJump@users.noreply.github.com> * Add NUnit migration tests for NestedContentMigratingConfig Co-authored-by: KevinJump <431231+KevinJump@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: KevinJump <431231+KevinJump@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support to migrate a nested content datatype and nested content content values to block list on import.
this will give use native support to migrate when importing legacy (e.g v13) usync files that contain a nested content element.