Skip to content

fix: 🐛 Ensure that device_scale.js is included in the docker build #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
moodyjmz wants to merge 1 commit into from
Closed

fix: 🐛 Ensure that device_scale.js is included in the docker build #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions develop/setup/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ sdkjs:
cd $(EO_DEV)/sdkjs/build && \
npm install && \
CC_PLATFORM=$(CC_PLATFORM) BUILD_ROOT=$(EO_ROOT) grunt $(SDKJS_OPTS) $(CFLAGS) develop && \
cp $(EO_DEV)/sdkjs/common/device_scale.js $(EO_ROOT)/sdkjs/common/device_scale.js && \
Copy link
Copy Markdown
Member

@juliusknorr juliusknorr Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to rather let grunt copy this?

Copy link
Copy Markdown
Member Author

@moodyjmz moodyjmz Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that, but when added to the list of files to copy over it started running closure compiler on each file it was copying, as it is the single file that is the exception. I agree though, it looks odd. I will look.

/usr/bin/documentserver-generate-allfonts.sh

## -----------------
Expand Down
Loading