fix: 🐛 Ensure that device_scale.js is included in the docker build#64
Closed
fix: 🐛 Ensure that device_scale.js is included in the docker build#64
Conversation
Signed-off-by: James Manuel <moodyjmz@users.noreply.github.com>
juliusknorr
reviewed
Apr 8, 2026
| cd $(EO_DEV)/sdkjs/build && \ | ||
| npm install && \ | ||
| CC_PLATFORM=$(CC_PLATFORM) BUILD_ROOT=$(EO_ROOT) grunt $(SDKJS_OPTS) $(CFLAGS) develop && \ | ||
| cp $(EO_DEV)/sdkjs/common/device_scale.js $(EO_ROOT)/sdkjs/common/device_scale.js && \ |
Member
There was a problem hiding this comment.
Would it make sense to rather let grunt copy this?
Member
Author
There was a problem hiding this comment.
I thought that, but when added to the list of files to copy over it started running closure compiler on each file it was copying, as it is the single file that is the exception. I agree though, it looks odd. I will look.
Member
Author
|
Moving to grunt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Euro-Office/sdkjs#19
#56