Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .github/app.template.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,17 @@ env_variables:
PYGEOAPI_POSTGRES_USER: "${PYGEOAPI_POSTGRES_USER}"
PYGEOAPI_POSTGRES_HOST: "${PYGEOAPI_POSTGRES_HOST}"
PYGEOAPI_POSTGRES_PORT: "${PYGEOAPI_POSTGRES_PORT}"
PYGEOAPI_POSTGRES_PASSWORD: "${PYGEOAPI_POSTGRES_PASSWORD}"
PYGEOAPI_POSTGRES_PASSWORD: |-
${PYGEOAPI_POSTGRES_PASSWORD}
Comment on lines +21 to +22

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid unindented multiline envsubst in block scalars

In the Render app.yaml step of both .github/workflows/CD_staging.yml and .github/workflows/CD_production.yml, envsubst < .github/app.template.yaml > app.yaml performs raw substitution, and this new |- form means only the first substituted line is indented. If any of these secrets contain a newline, the next line starts at column 1, producing invalid YAML and causing deployment (gcloud app deploy app.yaml) to fail; this affects each variable converted to block-scalar style here.

Useful? React with 👍 / 👎.

PYGEOAPI_SERVER_URL: "${PYGEOAPI_SERVER_URL}"
CLOUD_SQL_IAM_AUTH: "${CLOUD_SQL_IAM_AUTH}"
GCS_SERVICE_ACCOUNT_KEY: "${GCS_SERVICE_ACCOUNT_KEY}"
GCS_SERVICE_ACCOUNT_KEY: |-
${GCS_SERVICE_ACCOUNT_KEY}
GCS_BUCKET_NAME: "${GCS_BUCKET_NAME}"
AUTHENTIK_URL: "${AUTHENTIK_URL}"
AUTHENTIK_CLIENT_ID: "${AUTHENTIK_CLIENT_ID}"
AUTHENTIK_AUTHORIZE_URL: "${AUTHENTIK_AUTHORIZE_URL}"
AUTHENTIK_TOKEN_URL: "${AUTHENTIK_TOKEN_URL}"
SESSION_SECRET_KEY: "${SESSION_SECRET_KEY}"
SESSION_SECRET_KEY: |-
${SESSION_SECRET_KEY}
APITALLY_CLIENT_ID: "${APITALLY_CLIENT_ID}"