Skip to content

jir-ogc#562

Merged
jirhiker merged 1 commit intostagingfrom
jir-ogc
Feb 27, 2026
Merged

jir-ogc#562
jirhiker merged 1 commit intostagingfrom
jir-ogc

Conversation

@jirhiker
Copy link
Member

Why

This PR addresses the following problem / context:

  • Use bullet points here

How

Implementation summary - the following was changed / added / removed:

  • Use bullet points here

Notes

Any special considerations, workarounds, or follow-up work to note?

  • Use bullet points here

Copilot AI review requested due to automatic review settings February 27, 2026 19:24
@jirhiker jirhiker merged commit b710200 into staging Feb 27, 2026
9 checks passed
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0c904f61b6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +21 to +22
PYGEOAPI_POSTGRES_PASSWORD: |-
${PYGEOAPI_POSTGRES_PASSWORD}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid unindented multiline envsubst in block scalars

In the Render app.yaml step of both .github/workflows/CD_staging.yml and .github/workflows/CD_production.yml, envsubst < .github/app.template.yaml > app.yaml performs raw substitution, and this new |- form means only the first substituted line is indented. If any of these secrets contain a newline, the next line starts at column 1, producing invalid YAML and causing deployment (gcloud app deploy app.yaml) to fail; this affects each variable converted to block-scalar style here.

Useful? React with 👍 / 👎.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the App Engine app.yaml template used by the CD workflows to render secret-like environment variables more safely during envsubst, avoiding YAML quoting/escaping pitfalls for arbitrary secret contents.

Changes:

  • Switched select env_variables entries from quoted scalars to YAML literal block scalars (|-) for safer rendering of secret values.
  • Applied this to PYGEOAPI_POSTGRES_PASSWORD, GCS_SERVICE_ACCOUNT_KEY, and SESSION_SECRET_KEY.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants