forked from AstarVienna/irdb
-
Notifications
You must be signed in to change notification settings - Fork 0
ZSHTR-71 Latest model #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Yashvi-Sharma
wants to merge
13
commits into
dev_master
Choose a base branch
from
ZSHTR-71_newmodel
base: dev_master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
e5aacf0
ZSHTR-20 added selector wheel effect to scopesim, updates zshooter co…
Yashvi-Sharma 8d80fdd
ZSHTR-71 Adding first pass of the updated design
Yashvi-Sharma 41602d0
ZSHTR-71 Adding placeholder slit and dichroic dat files
Yashvi-Sharma 0a2b6a3
ZSHTR-71 Updated detector config to have 7 detectors
Yashvi-Sharma fa80c14
refactored old and new design into separate directories - part 1
Yashvi-Sharma 26e3d5f
added .DS_Store to gitignore
Yashvi-Sharma 5137cc5
refactoring part 2 - added new design folder
Yashvi-Sharma bd5a38e
minor fix
Yashvi-Sharma f4d5a80
Stub function for analytical spectral efficiency effect, updated ZSho…
Yashvi-Sharma e6e5ce4
Update Optical parameters and fix typo in spec yaml
baileyji c28dabf
Updated all configs in accordance with the trace params, added corres…
Yashvi-Sharma 37f6f37
Ported dichroic generating functions
Yashvi-Sharma 27487db
regenerated dichroic curves
Yashvi-Sharma File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -85,3 +85,5 @@ TEST*.fits | |
|
|
||
| # Pylint | ||
| .pylint.d/ | ||
|
|
||
| .DS_Store | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| # author : Y. Sharma | ||
| # date_created : 2025-09-24 | ||
| # status : Placeholder for the ZShooter selector mirror | ||
| # type : mirror:list | ||
| # outer_unit : m | ||
| # inner_unit : m | ||
| # angle_unit : degree | ||
| # temperature_unit : deg_C | ||
| # changes : | ||
| # - 2025-09-24 : created a placeholder file (copied from HAWKI) | ||
| # | ||
| name outer inner angle temperature action filename | ||
| M0_EntrWin 0.4 0.0 0 -273 transmission TER_window.dat | ||
| M1_Fold 0.4 0.0 0 -273 reflection TER_selector.dat |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| # author : Y. Sharma | ||
| # date_created : 2025-10-30 | ||
| # type : detector:quantum_efficiency | ||
| # description : quantum efficiency | ||
| # wavelength_unit: um | ||
| # action : transmission | ||
| # changes : | ||
| wavelength transmission | ||
| 0.29 0.0 | ||
| 0.30 1.0 | ||
| 1.00 1.0 | ||
| 3.00 1.0 | ||
| 3.01 0.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| # author : Y. Sharma | ||
| # date_created : 2025-09-24 | ||
| # status : placeholder | ||
| # type : mirror:reflection | ||
| # wavelength_unit : um | ||
| # description : | ||
| # changes : | ||
| # - 2025-09-24 : created a placeholder file (copied from HAWKI) | ||
| # | ||
| wavelength reflection | ||
| 0.3 0.985 | ||
| 3.0 0.985 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| # name : Entrance window spectral response | ||
| # description : Throughput of the entrance window (placeholder) | ||
| # author : Y. Sharma | ||
| # sources: | ||
| # date_created : 2025-09-24 | ||
| # status : Idea - guess pulled out of thin air | ||
| # type : window:transmission | ||
| # wavelength_unit : um | ||
| # | ||
| # changes : | ||
| # - 2025-09-24 : created a placeholder file (copied from HAWKI) | ||
| # | ||
| wavelength transmission reflection emissivity | ||
| 0.3 0 1 0 | ||
| 0.31 0.90 0 0.1 | ||
| 3.0 0.90 0 0.1 | ||
| 3.01 0 1 0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| ### Common effects list for ZShooter | ||
|
|
||
| object: instrument | ||
| alias: INST | ||
| name: ZShooter | ||
| description: Common effects from the ZShooter_v1 optics | ||
|
|
||
| properties: | ||
| temperature: -80 #TODO: check value | ||
| pixel_scale : 0.159574468085 #TODO update with real value | ||
| plate_scale : 10.638297872333334 #TODO update with real value | ||
|
|
||
| effects: | ||
| - name: Selector | ||
| description: Mirror selector for imaging or spectroscopic mode | ||
| class: SurfaceList | ||
| include: True | ||
| kwargs: | ||
| filename: LIST_ZShooter_mirrors.dat |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be 273 or maybe even 283?