Open
Conversation
…nfig in irdb to test the effect
…oter_v2 spec mode config with Echelle trace effects
…ponding dichroics, set all temperatures to -273 K for now, dichroics are applied using DichroicTree
baileyji
requested changes
Mar 17, 2026
Member
baileyji
left a comment
baileyji
left a comment
There was a problem hiding this comment.
Looks like several temps need some attention.
| # | ||
| name outer inner angle temperature action filename | ||
| M1 10.0 1.0 0. 0 reflection TC_mirror_aluminium.dat | ||
| M1 10.0 1.0 0. -273 reflection TC_mirror_aluminium.dat |
Member
There was a problem hiding this comment.
Should this be 273 or maybe even 283?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested latest model design configs together with ScopeSim updates