ZStack build failed for missing org.zstack:log4j2 dependency#1266
Open
lshmouse wants to merge 1 commit intozstackio:masterfrom
Open
ZStack build failed for missing org.zstack:log4j2 dependency#1266lshmouse wants to merge 1 commit intozstackio:masterfrom
lshmouse wants to merge 1 commit intozstackio:masterfrom
Conversation
live4thee
reviewed
Apr 3, 2020
| <artifactId>zbox</artifactId> | ||
| <version>${project.version}</version> | ||
| </dependency> | ||
| <dependency> |
Collaborator
There was a problem hiding this comment.
You moved the dependency to the "premium" profile - that is not expected.
Contributor
Author
There was a problem hiding this comment.
There is no org.zstack:log4j2 module under zstack and the maven can not find this dependency during building. So i guess the module is under premium version and move it there. Any suggestion about the placement of org.zstack:log4j2 dependency?
Contributor
Author
There was a problem hiding this comment.
@live4thee Could we just remove this log4j2 dependency?
Collaborator
There was a problem hiding this comment.
I checked the code base and it turned out that your patch is correct. I will merge it. Thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZStack build failed for missing org.zstack:log4j2 dependency.
Solution: Move the org.zstack:log4j2 dependency under premium profile.