Skip to content
This repository was archived by the owner on Nov 13, 2023. It is now read-only.

Add streaming APIs to Rest client#199

Merged
zFernand0 merged 9 commits intomasterfrom
rest_stream
Apr 12, 2019
Merged

Add streaming APIs to Rest client#199
zFernand0 merged 9 commits intomasterfrom
rest_stream

Conversation

@ChrisBoehmCA
Copy link
Copy Markdown
Contributor

Add new type of APIs to the Rest Client that allow the user to provide Node.js Streams rather than buffers to avoid out of memory exceptions when transferring large files.

Fix #192

Signed-off-by: ChrisBoehmCA <Christopher.Boehm@broadcom.com>
Signed-off-by: ChrisBoehmCA <Christopher.Boehm@broadcom.com>
Signed-off-by: ChrisBoehmCA <Christopher.Boehm@broadcom.com>
Signed-off-by: ChrisBoehmCA <Christopher.Boehm@broadcom.com>
Signed-off-by: ChrisBoehmCA <Christopher.Boehm@broadcom.com>
Signed-off-by: ChrisBoehmCA <Christopher.Boehm@broadcom.com>
Signed-off-by: ChrisBoehmCA <Christopher.Boehm@broadcom.com>
@ChrisBoehmCA ChrisBoehmCA requested a review from zFernand0 April 10, 2019 19:24
@ghost ghost assigned ChrisBoehmCA Apr 10, 2019
@ghost ghost added in progress labels Apr 10, 2019
@zFernand0
Copy link
Copy Markdown
Member

waiting on #200

Copy link
Copy Markdown
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these APIs

@zFernand0 zFernand0 added the release-minor Indicates a minor feature has been added label Apr 12, 2019
@ghost ghost assigned zFernand0 Apr 12, 2019
@zFernand0 zFernand0 merged commit 30336b3 into master Apr 12, 2019
@zFernand0 zFernand0 deleted the rest_stream branch April 12, 2019 18:23
@ghost ghost removed in progress labels Apr 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-minor Indicates a minor feature has been added

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create Rest Client methods that allow streaming of response and request data

2 participants