Skip to content

Add syntax highlighting for project symbol search #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
da-r-k wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add syntax highlighting for project symbol search #188

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f36e0e
feat: add syntax highlighting for project symbol search
da-r-k Feb 9, 2026
195b59e
style: formatted code with cargo fmt --all
da-r-k Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
195 changes: 194 additions & 1 deletion src/java.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ use zed_extension_api::{
self as zed, CodeLabel, CodeLabelSpan, DebugAdapterBinary, DebugTaskDefinition, Extension,
LanguageServerId, LanguageServerInstallationStatus, StartDebuggingRequestArguments,
StartDebuggingRequestArgumentsRequest, Worktree,
lsp::{Completion, CompletionKind},
lsp::{Completion, CompletionKind, Symbol, SymbolKind},
register_extension,
serde_json::{Value, json},
set_language_server_installation_status,
Expand Down Expand Up @@ -535,6 +535,199 @@ impl Extension for Java {
_ => None,
})
}

fn label_for_symbol(
&self,
_language_server_id: &LanguageServerId,
symbol: Symbol,
) -> Option<CodeLabel> {
let name = &symbol.name;

match symbol.kind {
SymbolKind::Class => {
// code: "class Name {}" → Tree-sitter: class_declaration
// display: "class Name"
let keyword = "class ";
let code = format!("{keyword}{name} {{}}");

Some(CodeLabel {
spans: vec![CodeLabelSpan::code_range(0..keyword.len() + name.len())],
filter_range: (keyword.len()..keyword.len() + name.len()).into(),
code,
})
}
SymbolKind::Interface => {
let keyword = "interface ";
let code = format!("{keyword}{name} {{}}");

Some(CodeLabel {
spans: vec![CodeLabelSpan::code_range(0..keyword.len() + name.len())],
filter_range: (keyword.len()..keyword.len() + name.len()).into(),
code,
})
}
SymbolKind::Enum => {
let keyword = "enum ";
let code = format!("{keyword}{name} {{}}");

Some(CodeLabel {
spans: vec![CodeLabelSpan::code_range(0..keyword.len() + name.len())],
filter_range: (keyword.len()..keyword.len() + name.len()).into(),
code,
})
Comment on lines +547 to +577
Copy link
Collaborator

@tartarughina tartarughina Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is pretty much the same if not for the keyword, cannot we simplify it removing repeated code?

}
SymbolKind::Constructor => {
// jdtls: "ClassName(Type, Type)"
let ctor_name = name.split('(').next().unwrap_or(name);
let rest = &name[ctor_name.len()..];
// Wrap in matching class for constructor_declaration AST node
let prefix = format!("class {ctor_name} {{ ");
let code = format!("{prefix}{ctor_name}() {{}} }}");
let ctor_start = prefix.len();

let mut spans = vec![CodeLabelSpan::code_range(
ctor_start..ctor_start + ctor_name.len(),
)];
if !rest.is_empty() {
spans.push(CodeLabelSpan::literal(rest.to_string(), None));
}

Some(CodeLabel {
spans,
filter_range: (0..name.len()).into(),
code,
})
}
SymbolKind::Method | SymbolKind::Function => {
// jdtls: "methodName(Type, Type) : ReturnType" or "methodName(Type)"
// display: "ReturnType methodName(Type, Type)" (Java declaration order)
let method_name = name.split('(').next().unwrap_or(name);
let after_name = &name[method_name.len()..];

let (params, return_type) = if let Some((p, r)) = after_name.split_once(" : ") {
(p, Some(r))
} else {
(after_name, None)
};

let ret = return_type.unwrap_or("void");
let class_open = "class _ { ";
let code = format!("{class_open}{ret} {method_name}() {{}} }}");

let ret_start = class_open.len();
let name_start = ret_start + ret.len() + 1;

// Display: "void methodName(String, int)"
let mut spans = vec![
CodeLabelSpan::code_range(ret_start..ret_start + ret.len()),
CodeLabelSpan::literal(" ".to_string(), None),
CodeLabelSpan::code_range(name_start..name_start + method_name.len()),
];
if !params.is_empty() {
spans.push(CodeLabelSpan::literal(params.to_string(), None));
}

// filter on "methodName(params)" portion of displayed text
let type_prefix_len = ret.len() + 1; // "void "
let filter_end = type_prefix_len + method_name.len() + params.len();
Some(CodeLabel {
spans,
filter_range: (type_prefix_len..filter_end).into(),
code,
})
}
SymbolKind::Field | SymbolKind::Property => {
// jdtls: "fieldName : Type" or just "fieldName"
// display: "Type fieldName" (Java declaration order)
if let Some((field_name, field_type)) = name.split_once(" : ") {
let class_open = "class _ { ";
let code = format!("{class_open}{field_type} {field_name}; }}");

let type_start = class_open.len();
let name_start = type_start + field_type.len() + 1;

// Display: "String fieldName"
let spans = vec![
CodeLabelSpan::code_range(type_start..type_start + field_type.len()),
CodeLabelSpan::literal(" ".to_string(), None),
CodeLabelSpan::code_range(name_start..name_start + field_name.len()),
];

let type_prefix_len = field_type.len() + 1; // "String "
Some(CodeLabel {
spans,
filter_range: (type_prefix_len..type_prefix_len + field_name.len()).into(),
code,
})
} else {
// No type info, just show the name
let class_open = "class _ { int ";
Copy link
Collaborator

@tartarughina tartarughina Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does it default to int?

let code = format!("{class_open}{name}; }}");
let name_start = class_open.len();

Some(CodeLabel {
spans: vec![CodeLabelSpan::code_range(
name_start..name_start + name.len(),
)],
filter_range: (0..name.len()).into(),
code,
})
}
}
SymbolKind::Constant => {
// Wrap in class; ALL_CAPS names get @constant from highlights.scm regex
let class_open = "class _ { static final int ";
Copy link
Collaborator

@tartarughina tartarughina Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why using int?

let code = format!("{class_open}{name}; }}");
let name_start = class_open.len();

Some(CodeLabel {
spans: vec![CodeLabelSpan::code_range(
name_start..name_start + name.len(),
)],
filter_range: (0..name.len()).into(),
code,
})
}
SymbolKind::EnumMember => {
// Wrap in enum for enum_constant AST node → @constant highlight
let prefix = "enum _ { ";
let code = format!("{prefix}{name} }}");
let name_start = prefix.len();

Some(CodeLabel {
spans: vec![CodeLabelSpan::code_range(
name_start..name_start + name.len(),
)],
filter_range: (0..name.len()).into(),
code,
})
}
SymbolKind::Variable => {
let class_open = "class _ { int ";
Copy link
Collaborator

@tartarughina tartarughina Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above regarding int usage

let code = format!("{class_open}{name}; }}");
let name_start = class_open.len();

Some(CodeLabel {
spans: vec![CodeLabelSpan::code_range(
name_start..name_start + name.len(),
)],
filter_range: (0..name.len()).into(),
code,
})
}
SymbolKind::Package | SymbolKind::Module | SymbolKind::Namespace => {
let keyword = "package ";
let code = format!("{keyword}{name};");

Some(CodeLabel {
spans: vec![CodeLabelSpan::code_range(0..keyword.len() + name.len())],
filter_range: (keyword.len()..keyword.len() + name.len()).into(),
code,
})
}
_ => None,
}
}
}

register_extension!(Java);