#552 Move signal handling from queue component to controller

[snewer]

Q	A
Is bugfix?	✔️
New feature?	❌
Breaks BC?	❌
Tests pass?	✔️
Fixed issues	#552

[terabytesoftw]

yii2-queue/composer.json

Line 19 in 5be821e

"php": ">=8.3",

[snewer]

yii2-queue/composer.json

Line 19 in 5be821e

"php": ">=8.3",

I just moved the code, but yes, I agree it’s unnecessary here, so I removed it

[terabytesoftw]

yii2-queue/composer.json

Line 19 in 5be821e

"php": ">=8.3",

I just moved the code, but yes, I agree it’s unnecessary here, so I removed it

The PHP 7.1 code is also unnecessary.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.98%. Comparing base (5be821e) to head (b1181f8).
⚠️ Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
src/drivers/amqp_interop/Command.php	0.00%	14 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #553      +/-   ##
============================================
- Coverage     46.54%   45.98%   -0.57%     
  Complexity      506      506              
============================================
  Files            44       44              
  Lines          1579     1581       +2     
============================================
- Hits            735      727       -8     
- Misses          844      854      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull request overview

This PR addresses #552 by preventing the AMQP Interop queue component from overriding process-wide UNIX signal handlers during application bootstrap, moving that behavior into the AMQP Interop console command lifecycle instead.

Changes:

• Removed pcntl signal handler registration from amqp_interop\Queue::init() to avoid global side effects at bootstrap.
• Added signal handler registration to amqp_interop\Command::init() so it only applies when the AMQP Interop queue command runs.
• Documented the change in CHANGELOG.md.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
src/drivers/amqp_interop/Queue.php	Stops registering signal handlers during component bootstrap to avoid impacting unrelated console commands.
src/drivers/amqp_interop/Command.php	Registers signal handlers at command init time so behavior is scoped to the AMQP Interop CLI command execution.
CHANGELOG.md	Adds an entry describing the signal-handling relocation.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The signal handler unconditionally calls posix_kill(posix_getpid(), $signal), but ext-posix isn’t required (composer.json only suggests ext-pcntl). In environments where pcntl_signal exists but posix functions are unavailable, this will fatal when a signal is received. Consider guarding with function_exists('posix_kill'), using getmypid() instead of posix_getpid(), and providing a safe fallback (e.g., exiting with a non-zero status) when posix_kill isn’t available.

Suggested change

	posix_kill(posix_getpid(), $signal);
	if (function_exists('posix_kill')) {
	posix_kill(getmypid(), $signal);
	} else {
	// Fallback when POSIX functions are unavailable.
	exit(1);
	}

[Copilot]

This change addresses a signal-handling breakage (per issue #552 / #379), so the changelog entry label likely should be Bug rather than Enh to match the project’s changelog categories.