Merged
Conversation
When resizing the LUN underneath a PV for and SR ensure that the size property in `/sys/block/<device>` and `sg_readcap` agree on the device size before request `pvresize`. Intermittent failures have been observered where `pvresize` would be called and not increase the size of the PV. It appears that this has some relation to data in the kernel device not seeing the update as being complete. Signed-off-by: Mark Syms <mark.syms@citrix.com>
With the introduction of the systemd templated service for the garbage collection process the previous handler for unhandled errors was no longer in the execution path. Update to ensure that both foreground and background GC processes go through the same error log process. Signed-off-by: Mark Syms <mark.syms@citrix.com>
Some dangling left over conversion from Python2 Signed-off-by: Mark Syms <mark.syms@citrix.com>
In coalesce leaf, after triggering the regular GC, ensure it has completed before proceeding with the VM suspend. Signed-off-by: Mark Syms <mark.syms@citrix.com>
Signed-off-by: Mark Syms <mark.syms@citrix.com>
TimSmithCtx
approved these changes
Jan 15, 2026
LunfanZhang
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.