Open
Conversation
8cc7823 to
c1572a4
Compare
Replacing ls command by find Signed-off-by: imakiro <pj2000@hotmail.fr>
c1572a4 to
fd9e523
Compare
Contributor
|
I think there are good reasons why we would not want this to be enabled by default given the significant change in behaviour. |
Author
This seemed like a good idea, do you mind explaining which element is impacted significantly ? using a sane default of 1 would simply present the same behaviour as right now. |
|
Is this something that can be reviewed again? I'm trying not to present every path on my TrueNAS to the network. I already have too many. |
|
@Nick-085 have you tried the modifications? It might be easy to test, and having more feedback might help the upstream to be more confident on merging this at some point :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change from ls to find enable a simple recursion control.