Open
Conversation
danielinux
requested changes
Jan 15, 2026
Member
danielinux
left a comment
There was a problem hiding this comment.
Thanks for the contribution! This port looks well done. I should get a board today or tomorrow to test. Meanwhile after a first look:
- An entry in docs/Targets.md is missing. We usually put "getting started" information about the specific target in that file.
- To ensure we don't break this, we should add at least a build test as github workflow.
- It is unusual to toggle LEDs or in general any interaction with the bootloader is discouraged. I would kindly ask you to move the nrf54lm20_dk.c code to test_app, and feel free to call monitor/tests/led blinking from there at will. The secure bootloader should not include hal_monitor_init, and that should not be part of the hal_ workspace, neither should the bootloader expose any unnecessary interactions except the very devices used for booting/updating (e.g. SPI flash or UART updates). We do have a wolfBoot_printf facility that could be mapped to the UART if you want (not all targets include this) but it should be disabled by default unless PRINTF_ENABLED is explicitly set.
- Avoid initializing grtc and/or calling sleep in the bootloader. Avoid unnecessary interrupts. Keep the bootloader API minimal (hal_init to set clocks and initialize peripherals, flash write/erase driver, hal_prepare_boot to deinitialize peripherals and unset clocks if needed) + optional uart.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is support added for the Nordic NRF54LM20, and specifically for the NRF54LM20-DK development board.