RFC 207: step_wait_promise method

[sadym-chromium]

---

Preview

[Ms2ger]

What happens if the promise rejects?

[sadym-chromium]

What happens if the promise rejects?

The step will fail with the rejection reason

[Ms2ger]

Please clarify in the rfc

[sadym-chromium]

Please clarify in the rfc

Right, I missed it. Done.

[sadym-chromium]

I assume the RFC is accepted. @past could you please merge?

[past]

I will give this another week, given that it was filed after our last WPT infra meeting, since many people are still out of office. I see no objections and one approval, so I expect it will be swiftly approved. I will bring it up in our meeting next Tuesday.

[gsnedders]

Do we want to add a Test.step_wait_promise_done as well?

Test.step_wait already optionally takes a Promise as its first argument, so is this basically just:

Test.prototype.step_wait_promise(promise, description, timeout) {
    return this.step_wait_func(() => promise, description, timeout)
}

[sadym-chromium]

indeed, this should work. Thanks!

[sadym-chromium]

Oh, wait. The step_wait_func does not respect the timeout of the cond:

var wait_for_inner = test_this.step_func(() => {
    Promise.resolve(cond()).then( // `step_wait_func` waits for the `cond` disregarding `timeout` argument.
        step, // Timeout is checked here
        test_this.unreached_func("step_wait_func"));
});

[sadym-chromium]

But perhaps this can be fixed in the step_wait_func method instead.