feat: add OCI reference support to plugin test command#56
Open
brooksmtownsend wants to merge 2 commits intowasmCloud:mainfrom
Open
feat: add OCI reference support to plugin test command#56brooksmtownsend wants to merge 2 commits intowasmCloud:mainfrom
brooksmtownsend wants to merge 2 commits intowasmCloud:mainfrom
Conversation
Signed-off-by: Brooks Townsend <brooks@cosmonic.com>
This implementation follows the same pattern as the `wash inspect` command to support different input types for the `wash plugin test` command: - **File**: Direct .wasm file path (existing behavior) - **Directory**: Project directory with build capability (existing behavior) - **OCI Reference**: Remote container registry references (new feature) Changes made: - Updated TestCommand.plugin field from PathBuf to String to handle OCI refs - Added OCI pull functionality with caching support - Enhanced error handling for different input types - Updated integration tests to work with new String type - Added debug logging for better troubleshooting The implementation reuses existing OCI infrastructure from the inspect command and maintains backward compatibility for file and directory inputs. Resolves wasmCloud#14 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
|
This repository has been merged into wasmCloud/wasmCloud. Please re-open this PR against wasmCloud/wasmCloud:main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This implementation adds OCI reference support to the
wash plugin testcommand, following the same pattern as the existingwash inspectcommand. The command now supports three types of input:.wasmfile paths (existing behavior)ghcr.io/wasmcloud/plugin:latest(new feature)Changes Made
TestCommand.pluginfield fromPathBuftoStringto handle OCI referencesinspectcommandTest Plan
./plugins/inspect/target/wasm32-wasip1/release/inspect.wasm./plugins/inspect(builds and runs)ghcr.io/wasmcloud/components/http-hello-world-rust:0.1.0cargo +nightly fmtcargo clippychecksExample Usage
After this implementation, users can run:
Implementation Notes
This implementation reuses the existing OCI client infrastructure from the
inspectcommand, including:The change maintains backward compatibility - all existing use cases continue to work exactly as before.
Resolves #14
🤖 Generated with Claude Code