Skip to content

Fix GitHub template#5109

Open
wayneforrest wants to merge 2 commits intowailsapp:v3-alphafrom
wayneforrest:fix-github-template
Open

Fix GitHub template#5109
wayneforrest wants to merge 2 commits intowailsapp:v3-alphafrom
wayneforrest:fix-github-template

Conversation

@wayneforrest
Copy link
Copy Markdown

@wayneforrest wayneforrest commented Apr 2, 2026

Fixes #5108

#5108

Type of change

Please select the option that is relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration using wails doctor.

  • Windows
  • macOS
  • Linux

If you checked Linux, please specify the distro and version.

Test Configuration

Please paste the output of wails doctor. If you are unable to run this command, please describe your environment in as much detail as possible.

Checklist:

  • I have updated website/src/pages/changelog.mdx with details of this PR
  • My code follows the general coding style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Summary by CodeRabbit

  • Documentation
    • Updated the feedback URL in the GitHub PR template to the correct v3 feedback page.
    • Added a changelog entry under "Fixed" noting the PR template URL correction.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 40ed11f6-197f-48a6-9d3f-15c54ec05998

📥 Commits

Reviewing files that changed from the base of the PR and between f1ddafb and 8b3b74c.

📒 Files selected for processing (1)
  • v3/UNRELEASED_CHANGELOG.md
✅ Files skipped from review due to trivial changes (1)
  • v3/UNRELEASED_CHANGELOG.md

Walkthrough

Updated the feedback guide URL in the pull request template from https://v3alpha.wails.io/getting-started/feedback/ to https://v3alpha.wails.io/feedback/. Also added a corresponding entry to v3/UNRELEASED_CHANGELOG.md referencing the fix (#5108).

Changes

Cohort / File(s) Summary
PR Template
.github/pull_request_template.md
Changed feedback URL from https://v3alpha.wails.io/getting-started/feedback/ to https://v3alpha.wails.io/feedback/.
Changelog
v3/UNRELEASED_CHANGELOG.md
Appended a Fixed entry: “Fix git PR template to point to the correct feedback URL” referencing #5108.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

Documentation, Bug, v3-alpha, size:XS

Poem

🐰 I hopped through links both near and far,
A stray path found beneath the PR star,
I fixed the route, then gave a cheer,
Now feedback lands exactly where it’s clear! ✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is mostly incomplete; it lacks a summary section, testing details, and most checklist items are unchecked despite being required. Add a description summary explaining the URL change, provide testing details, and ensure checklist items are addressed or documented.
Title check ❓ Inconclusive The title 'Fix GitHub template' is vague and doesn't clearly indicate what specific URL change was made to the template. Consider a more specific title like 'Fix PR template feedback URL' to better communicate the actual change.
✅ Passed checks (3 passed)
Check name Status Explanation
Linked Issues check ✅ Passed The code changes directly address issue #5108 by updating the PR template URL from the incorrect path to the correct feedback URL.
Out of Scope Changes check ✅ Passed All changes are in-scope: PR template URL correction and corresponding changelog entry directly match issue #5108 requirements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@leaanthony
Copy link
Copy Markdown
Member

Thanks for raising this. Did you update v3/pkg/application/transport_event_ipc.go in error?
Please could you add an entry to the changelog located at v3/UNRELEASED_CHANGELOG.md? Thanks!

@wayneforrest
Copy link
Copy Markdown
Author

Thanks @leaanthony --- yes it was a mistake to change v3/pkg/application/transport_event_ipc.go that should / is part of another PR.

@wayneforrest wayneforrest force-pushed the fix-github-template branch from c5906c4 to f1ddafb Compare April 3, 2026 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants