Skip to content

Comments

Fixed vscolde-single-select value not updated after onOptionClick event#604

Merged
bendera merged 1 commit intovscode-elements:pr-604-single-select-value-update-fixfrom
sebjulliand:fixSingleSelectOnClickValueUpdate
Feb 21, 2026
Merged

Fixed vscolde-single-select value not updated after onOptionClick event#604
bendera merged 1 commit intovscode-elements:pr-604-single-select-value-update-fixfrom
sebjulliand:fixSingleSelectOnClickValueUpdate

Conversation

@sebjulliand
Copy link
Contributor

While using a vscolde-single-select element and changing it's value by clicking, it's value in its parent form is always ''.
This issue can easly be reproduced from this documentation example.
image

This PR fixes this by passing the actual selected value to the form.

Signed-off-by: Seb Julliand <sebjulliand@gmail.com>
@bendera bendera changed the base branch from main to pr-604-single-select-value-update-fix February 21, 2026 22:15
@bendera bendera merged commit be01554 into vscode-elements:pr-604-single-select-value-update-fix Feb 21, 2026
0 of 3 checks passed
bendera added a commit that referenced this pull request Feb 21, 2026
bendera added a commit that referenced this pull request Feb 21, 2026
@sebjulliand sebjulliand deleted the fixSingleSelectOnClickValueUpdate branch February 22, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants