Skip to content

New package: herbe-1.0.0#27195

Closed
tuxliban wants to merge 4 commits intovoid-linux:masterfrom
tuxliban:herbe
Closed

New package: herbe-1.0.0#27195
tuxliban wants to merge 4 commits intovoid-linux:masterfrom
tuxliban:herbe

Conversation

@tuxliban
Copy link
Copy Markdown
Contributor

Daemon-less notifications without D-Bus. Minimal and lightweight

@@ -0,0 +1,95 @@
diff --git a/config.def.h b/config.def.h
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elaborate on reasoning about this patch or mention the source if any

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got the patch from here and it was convenient for me to add it so that users can modify the settings from the Xresources file and not compile it from source.

Copy link
Copy Markdown
Member

@Piraty Piraty Dec 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reference the origin of that patch in the patch header. nobody reads github. side-note: Void won't patch in random features that upstream doesn't want/reviewed

patch_args="-Np1"

do_build() {
export CFLAGS=${CFLAGS}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this

  1. doesn't build anything and renders the package empty (except license)
  2. should not be necessary as CFLAGS is already in env

Copy link
Copy Markdown
Contributor Author

@tuxliban tuxliban Dec 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously I tried to build the binary directly with the help of the gnu-makefile build script, but despite having specified the makedepends in the middle of the process it gives me an error for missing a header.
The only way I was able to build the binary was as the template currently is.

-> $ ./xbps-src -f pkg herbe
=> xbps-src: updating repositories for host (x86_64-musl)...
[*] Updating repository `https://alpha.us.repo.voidlinux.org/current/musl/x86_64-musl-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/musl/x86_64-musl-repodata' ...
[*] Updating repository `https://alpha.de.repo.voidlinux.org/current/musl/nonfree/x86_64-musl-repodata' ...
=> xbps-src: updating software in / masterdir...
=> xbps-src: cleaning up / masterdir...
=> herbe-1.0.0_1: removing autodeps, please wait...
=> herbe-1.0.0_1: building [gnu-makefile] for x86_64-musl...
   [target] libXft-devel-2.3.3_1: found (https://alpha.de.repo.voidlinux.org/current/musl)
   [target] freetype-devel-2.10.4_1: found (https://alpha.de.repo.voidlinux.org/current/musl)
=> herbe-1.0.0_1: installing target dependencies: libXft-devel-2.3.3_1 freetype-devel-2.10.4_1 ...
=> herbe-1.0.0_1: running do-fetch hook: 00-distfiles ...
=> herbe-1.0.0_1: running do-extract hook: 00-distfiles ...
=> herbe-1.0.0_1: extracting distfile(s), please wait...
=> herbe-1.0.0_1: running do-patch hook: 00-patches ...
=> herbe-1.0.0_1: patching: Xresources.diff.
=> herbe-1.0.0_1: running pre-configure hook: 00-gnu-configure-asneeded ...
=> herbe-1.0.0_1: running pre-configure hook: 01-override-config ...
=> herbe-1.0.0_1: running pre-configure hook: 02-script-wrapper ...
=> herbe-1.0.0_1: running pre-build hook: 02-script-wrapper ...
=> herbe-1.0.0_1: running do_build ...
cp config.def.h config.h
cc herbe.c -fstack-clash-protection -D_FORTIFY_SOURCE=2 -mtune=generic -march=native -O2 -pipe    -o herbe
In file included from herbe.c:2:
/usr/include/X11/Xft/Xft.h:39:10: fatal error: ft2build.h: No such file or directory
   39 | #include <ft2build.h>
      |          ^~~~~~~~~~~~
compilation terminated.
make: *** [Makefile:12: herbe] Error 1
=> ERROR: herbe-1.0.0_1: do_build: '${make_cmd} CC="$CC" CXX="$CXX" LD="$LD" AR="$AR" RANLIB="$RANLIB" CPP="$CPP" AS="$AS" OBJCOPY="$OBJCOPY" OBJDUMP="$OBJDUMP" CFLAGS="$CFLAGS" CXXFLAGS="$CXXFLAGS" LDFLAGS="$LDFLAGS" ${makejobs} ${make_build_args} ${make_build_target}' exited with 2
=> ERROR:   in do_build() at common/build-style/gnu-makefile.sh:9

It should also be said that the program does not have a user manual since its use is relatively very simple

Copy link
Copy Markdown
Member

@Piraty Piraty Dec 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as the template is now, the package just ships one file (the license).
the error indicates you're missing a package in makedepends (hint: it's freetype-devel. you can use xlocate from xtools to find files)

@tuxliban tuxliban requested a review from Piraty December 17, 2020 22:45
@ericonr ericonr added the new-package This PR adds a new package label Dec 20, 2020
@biopsin biopsin mentioned this pull request Apr 28, 2021
3 tasks
@ericonr
Copy link
Copy Markdown
Member

ericonr commented Apr 28, 2021

Closed with #30558

@ericonr ericonr closed this Apr 28, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 27, 2021
@tuxliban tuxliban deleted the herbe branch September 24, 2021 06:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

new-package This PR adds a new package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants