Open
Conversation
The id variable is missing in this function's scope. Thus, I commented it out to "fix" the build. I would assume this is safe because it seems like this function is not called at all. This was already addressed in virtualabs#12 and should close virtualabs#12.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the nRF51822 microcontroller on the Bornhack Badge 2018.
First, the bug described in issue #12 is addressed so that compilation is possible. Then a new config for the board was added and the Makefile was adjusted accordingly.
I'm not sure how useful this PR is overall, as this badge was estimated only given to 500 people. But it doesn't change anything and at least it helped me.