fix #1582: Missing Poster attribute on Video Element#1684
Open
rjmoggach wants to merge 1 commit intovidstack:mainfrom
Open
fix #1582: Missing Poster attribute on Video Element#1684rjmoggach wants to merge 1 commit intovidstack:mainfrom
rjmoggach wants to merge 1 commit intovidstack:mainfrom
Conversation
Fix poster attribute only being set when nativeControls is enabled. The poster was incorrectly conditional on nativeControls in both the core provider element and React provider, causing poster images to not display when using custom video controls. Changes: - Remove nativeControls condition from poster attribute in provider-element.ts - Remove nativeControls condition from poster attribute in React provider.tsx Fixes poster display for video players using custom controls instead of native browser controls. Summary of Changes Made: Fixed Files: 1. /packages/vidstack/src/elements/define/provider-element.ts - Line 121 (but this wasn't the actual issue for React apps) 2. /packages/react/src/components/provider.tsx - Line 171 (this was the real fix)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Fix poster attribute only being set when nativeControls is enabled.
The poster was incorrectly conditional on nativeControls in both the
core provider element and React provider, causing poster images to
not display when using custom video controls.
Changes:
nativeControlscondition from poster attribute inprovider-element.tsnativeControlscondition from poster attribute in Reactprovider.tsxFixes poster display for video players using custom controls instead
of native browser controls.
Summary of Changes Made:
Fixed Files:
/packages/vidstack/src/elements/define/provider-element.ts- Line 121 (but this wasn't the actual issue for React apps)/packages/react/src/components/provider.tsx- Line 171 (this was the real fix for react)Ready?
Tried it with buck bunny and seems to work.