Conversation
- Added `CommandSupport::BuiltIn` to distinguish between scripts and built-in commands. - Updated `NodeValidator` to recognize common npm/yarn/pnpm/bun built-in commands (install, test, start, etc.) even if not present in `scripts`. - Updated `select_runner` to accept runners with built-in command support. - Updated `build_command` to execute built-in commands directly (e.g., `npm install`) instead of via `run` (e.g., `npm run install`), while preserving `run` behavior for scripts and unknown commands. - Added tests to verify built-in command execution and script priority.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
1 participant
This PR adds support for executing built-in commands (like
install,test,start) for Node.js runners (npm, yarn, pnpm, bun) even when they are not explicitly defined inpackage.jsonscripts.Previously,
run installwould fail ifinstallwas not inscripts, as it would try to executenpm run install. Now, it correctly detectsinstallas a built-in command and executesnpm install.If a script with the same name exists (e.g.,
"test": "echo custom test"), it takes priority and is executed vianpm run test.This improves the user experience by making
runwork seamlessly with standard package manager commands without requiring explicit script definitions.PR created automatically by Jules for task 16642547342770374483 started by @insign