Conversation
Update `guessBin` in `ProcessManager.php` to pass `null` as the default path instead of `'/usr/bin/rclone'`. This fixes a bug where the missing executable exception was never thrown, as the method would return the hardcoded default path instead of returning `null` when `rclone` wasn't found in the system `$PATH`. Co-authored-by: insign <1113045+insign@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
The fix rectifies the usage of
ExecutableFinder::findinProcessManager::guessBin. Previously, the method passed a hardcoded string'/usr/bin/rclone'as the default fallback parameter, which meant that whenrclonewasn't actually present on the system, the application bypassed the intendedRuntimeExceptioncheck because it evaluated'/usr/bin/rclone'instead ofnull. This led to a confusing generic error later when the system attempted to execute a path that didn't exist. This commit ensures the correctRuntimeExceptionis thrown gracefully.Files changed:
src/ProcessManager.php: Replaced'/usr/bin/rclone'withnullwhen checking for binary presence.PR created automatically by Jules for task 4721382692237561927 started by @insign