Skip to content

feat: Add rename functionality to SevenZip using 7z rn#43

Closed
insign wants to merge 1 commit intomainfrom
feature/rename-files-3955569089342997568
Closed

feat: Add rename functionality to SevenZip using 7z rn#43
insign wants to merge 1 commit intomainfrom
feature/rename-files-3955569089342997568

Conversation

@insign
Copy link
Copy Markdown
Contributor

@insign insign commented Mar 31, 2026

This pull request adds support for renaming files inside an existing archive using the 7z rn command. It introduces the rename(array $renames) method to the SevenZip class.

Key changes:

  • SevenZip::rename() handles associative arrays, mapping old filenames to their new names, executing 7z rn accurately.
  • Adds comprehensive PHPUnit tests inside SevenZipTest.php, covering normal operation and handling the bzip2 edge case gracefully (bzip2 lacks native rename).
  • Resolves modern PHP 8.4 implicit null deprecations for ?Throwable $previous and ?string $value.
  • Drops resolved errors from the phpstan-baseline.neon file.
  • Formats code according to PSR-12.

PR created automatically by Jules for task 3955569089342997568 started by @insign

- Add `rename()` method to `SevenZip` class using `7z rn`
- Support associative arrays for `[old => new]` file renaming
- Add `testRename` dependent on `testVerify`, validating `rename` success
- Skip `bzip2` gracefully by expecting `RuntimeException` since it lacks internal file rename support
- Fix PHP 8.4 implicit nullable parameter deprecations in `src`
- Update PHPStan baseline to reflect the resolved PHP 8.4 deprecations
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@chatgpt-codex-connector
Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@insign insign closed this Apr 1, 2026
@insign insign deleted the feature/rename-files-3955569089342997568 branch April 1, 2026 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant