fix(next): export track from Next.js binding and fix hard-refresh event loss#198
Merged
fix(next): export track from Next.js binding and fix hard-refresh event loss#198
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
feugy
requested review from
timolins and
tobiaslins
and removed request for
timolins
tobiaslins
approved these changes
Mar 31, 2026
Collaborator
tobiaslins
left a comment
tobiaslins
left a comment
There was a problem hiding this comment.
Thanks for finding and fixing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🖖🏻 What's in there?
Export
trackfrom@vercel/analytics/next— the Next.js binding was missing atrackexport, requiring users to import it from a the react entry point.Fix
track()silently dropping events on hard refresh — whentrack()was called beforeinject()ran (which happens on hard refresh because React runs children'suseEffects before parents'),window.vawas stillundefinedand the optional chain?.silently swallowed the event. Fixed by callinginitQueue()at the start oftrack()so events are always buffered, regardless of initialization order.Type improvements in
types.ts— reorganized type declarations and addedTrackEventPayloadand apayloadfield onCustomEventinBeforeSendEventfor better typing of thebeforeSendcallback.🔬 Notes to reviewers
I made an Experiment page in the next-15 demo app to illustrate the lost tracked events. And slightly improved the look of these test pages.
Also fixed the damn e2e tests that were failing since ages